From: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
To: linux-kernel@vger.kernel.org
Cc: mingo@kernel.org, laijs@cn.fujitsu.com, dipankar@in.ibm.com,
akpm@linux-foundation.org, mathieu.desnoyers@efficios.com,
josh@joshtriplett.org, niv@us.ibm.com, tglx@linutronix.de,
peterz@infradead.org, rostedt@goodmis.org, dhowells@redhat.com,
edumazet@google.com, darren@dvhart.com, fweisbec@gmail.com,
oleg@redhat.com, sbw@mit.edu
Subject: [PATCH v3 tip/core/timers 0/5] Crude timer-wheel latency hacks
Date: Wed, 15 Jan 2014 20:02:03 -0800 [thread overview]
Message-ID: <20140116040203.GA5206@linux.vnet.ibm.com> (raw)
Hello!
The following five patches provide some crude timer-wheel latency patches.
I understand that a more comprehensive solution is in progress, but in the
meantime, these patches work well in cases where a given CPU has either
zero or one timers pending, which is a common case for NO_HZ_FULL kernels.
Note that these patches do not help in the case where a given timer wheel
has a pair of widely separated timers, while the more comprehensive
solution is likely to handle more gracefully. So, on the off-chance
that this is helpful to someone, the individual patches are as follows:
1. Add ->all_timers field to tbase_vec to count all timers, not
just the non-deferrable ones.
2. Avoid jiffy-at-a-time stepping when the timer wheel is empty.
3. Avoid jiffy-at-a-time stepping when the timer wheel transitions
to empty.
4. Avoid jiffy-at-a-time stepping after a timer is added to an
initially empty timer wheel.
5. Make internal_add_timer() update ->next_timer if ->active_timers == 0,
courtesy of Oleg Nesterov.
Differences from v2:
o Add patch #5 from Oleg.
o Move the check for adding to an empty timer wheel from mod_timer()
to internal_add_timer(), as suggested by Oleg Nesterov.
o Addressed review comments from Oleg, Steven Rostedt, Josh Triplett,
and Fengguang Wu.
Differences from v1:
o Fix an embarrassing bug located by Oleg Nesterov where the
timer wheel could be judged to be empty even if it contained
deferrable timers.
Thanx, Paul
------------------------------------------------------------------------
b/kernel/timer.c | 30 ++++++++++++++++++++++++++++--
1 file changed, 28 insertions(+), 2 deletions(-)
next reply other threads:[~2014-01-16 4:02 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-16 4:02 Paul E. McKenney [this message]
2014-01-16 4:02 ` [PATCH tip/core/timers 1/5] timers: Track total number of timers in list Paul E. McKenney
2014-01-16 4:02 ` [PATCH tip/core/timers 2/5] timers: Reduce __run_timers() latency for empty list Paul E. McKenney
2014-01-16 4:02 ` [PATCH tip/core/timers 3/5] timers: Reduce future __run_timers() latency for newly emptied list Paul E. McKenney
2014-01-16 4:02 ` [PATCH tip/core/timers 4/5] timers: Reduce future __run_timers() latency for first add to empty list Paul E. McKenney
2014-01-16 4:02 ` [PATCH tip/core/timers 5/5] timers: Make internal_add_timer() update ->next_timer if ->active_timers == 0 Paul E. McKenney
2014-01-16 5:47 ` [PATCH v3 tip/core/timers 0/5] Crude timer-wheel latency hacks Josh Triplett
2014-01-16 13:44 ` Peter Zijlstra
2014-01-16 14:31 ` Oleg Nesterov
2014-01-16 14:44 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140116040203.GA5206@linux.vnet.ibm.com \
--to=paulmck@linux.vnet.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=darren@dvhart.com \
--cc=dhowells@redhat.com \
--cc=dipankar@in.ibm.com \
--cc=edumazet@google.com \
--cc=fweisbec@gmail.com \
--cc=josh@joshtriplett.org \
--cc=laijs@cn.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=mingo@kernel.org \
--cc=niv@us.ibm.com \
--cc=oleg@redhat.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=sbw@mit.edu \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox