public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Peter Zijlstra <peterz@infradead.org>
To: Vince Weaver <vincent.weaver@maine.edu>
Cc: Will Deacon <will.deacon@arm.com>,
	Chad Paradis <chad.paradis@umit.maine.edu>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Paul Mackerras <paulus@samba.org>, Ingo Molnar <mingo@redhat.com>,
	Arnaldo Carvalho de Melo <acme@ghostprotocols.net>,
	Stephane Eranian <eranian@gmail.com>
Subject: Re: [patch/rfc] perf on raspberry-pi without overflow interrupt
Date: Thu, 16 Jan 2014 18:31:10 +0100	[thread overview]
Message-ID: <20140116173110.GA9655@laptop.programming.kicks-ass.net> (raw)
In-Reply-To: <alpine.DEB.2.10.1401161209280.1996@vincent-weaver-1.um.maine.edu>

On Thu, Jan 16, 2014 at 12:13:10PM -0500, Vince Weaver wrote:
> On Tue, 14 Jan 2014, Peter Zijlstra wrote:
> 
> > On Mon, Jan 13, 2014 at 11:55:17PM -0500, Vince Weaver wrote:
> 
> > > I don't see an existing pmu capabilities struct... or do you mean
> > > coming up with one?
> > 
> > Yeah, adding one.
> 
> So would it be a struct, or just an integer with flags?

I hadn't really considered that; per the below proposed names I suppose
I was thinking of 'unsigned long flags' with #define PMU_HAS_flags. But
a named struct would work too I suppose.

> > > Would it only hold an "overflow_interrupt_available" flag, or are
> > > there other generic capabilities it would be handy to know about?
> > 
> > Possible (other) flags could be:
> > 
> >   PMU_HAS_INT      -- would allow sampling events
> >   PMU_HAS_PRECISE  -- would allow any ::precise value
> >   PMU_HAS_FILTER   -- would allow all os/user/etc. flags
> 
> should we export these to userspace somehow?
> 
> It would be handy to be able to tell you're getting EOPNOTSUP because
> PMU_HAS_INT is not set for your pmu, rather than trying to guess why 
> things are failing.

Yeah I suppose we could do something like that. Maybe something like:

# cat /sys/bus/event_source/devices/cpu/flags
int precise filter

?

  reply	other threads:[~2014-01-16 17:31 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-08 21:28 [patch/rfc] perf on raspberry-pi without overflow interrupt Vince Weaver
2014-01-08 22:23 ` Stephane Eranian
2014-01-08 22:53 ` Peter Zijlstra
2014-01-09  3:47   ` Vince Weaver
2014-01-09 10:19     ` Will Deacon
2014-01-10  4:08       ` Vince Weaver
2014-01-10  9:40         ` Peter Zijlstra
2014-01-14  4:55           ` Vince Weaver
2014-01-14 10:57             ` Peter Zijlstra
2014-01-16 17:13               ` Vince Weaver
2014-01-16 17:31                 ` Peter Zijlstra [this message]
2014-01-17  5:45                   ` Vince Weaver
2014-02-24 10:46                     ` Will Deacon
2014-02-24 15:37                       ` Vince Weaver
2014-05-07 17:29                         ` Will Deacon
2014-05-07 21:21                           ` Vince Weaver
2014-05-07 21:23                             ` Will Deacon
2014-01-10 10:08         ` Will Deacon
2014-01-10 10:43           ` Stephane Eranian
2014-01-10 13:54             ` Vince Weaver
2014-01-14  4:42           ` Vince Weaver
2014-01-15 18:38             ` Will Deacon
2014-01-16 16:13               ` Vince Weaver

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140116173110.GA9655@laptop.programming.kicks-ass.net \
    --to=peterz@infradead.org \
    --cc=acme@ghostprotocols.net \
    --cc=chad.paradis@umit.maine.edu \
    --cc=eranian@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=paulus@samba.org \
    --cc=vincent.weaver@maine.edu \
    --cc=will.deacon@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox