linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Fengguang Wu <fengguang.wu@intel.com>
To: Dave Hansen <dave.hansen@intel.com>
Cc: LKML <linux-kernel@vger.kernel.org>, lkp@linux.intel.com
Subject: Re: [slub shrink] 0f6934bf16: +191.9% vmstat.system.cs
Date: Fri, 17 Jan 2014 08:26:02 +0800	[thread overview]
Message-ID: <20140117002601.GB1413@localhost> (raw)
In-Reply-To: <52D82F13.9070309@intel.com>

[-- Attachment #1: Type: text/plain, Size: 1938 bytes --]

On Thu, Jan 16, 2014 at 11:12:19AM -0800, Dave Hansen wrote:
> On 01/15/2014 07:07 PM, kernel test robot wrote:
> > 9a0bb2966efbf30  0f6934bf1695682e7ced973f6  
> > ---------------  -------------------------  
> >    8235933 ~ 2%     +80.6%   14872911 ~ 3%  lkp-sbx04/micro/will-it-scale/read2
> >    8235933          +80.6%   14872911       TOTAL interrupts.RES
> > 
> > 9a0bb2966efbf30  0f6934bf1695682e7ced973f6  
> > ---------------  -------------------------  
> >     161531 ~ 7%    +191.9%     471544 ~ 9%  lkp-sbx04/micro/will-it-scale/read2
> >     161531         +191.9%     471544       TOTAL vmstat.system.cs
> > 
> > 9a0bb2966efbf30  0f6934bf1695682e7ced973f6  
> > ---------------  -------------------------  
> >      32943 ~ 1%     +71.8%      56599 ~ 3%  lkp-sbx04/micro/will-it-scale/read2
> >      32943          +71.8%      56599       TOTAL vmstat.system.in
> 
> I suspect that something is wrong with that system.  My 160-cpu system
> does about 40,000 interrupts/sec and ~4300 context switches/sec when
> running 160 read2_processes.  I wonder if you're hitting swap or the
> dirty limits or something.  Are you running it with way more threads
> than it has CPUs?

lkp-sbx04 has 64 CPU threads, and I'm running will-it-scale with
thread numbers 1 16 24 32 48 64 8 

> Also, are those will-it-scale tests the threaded or process versions?

Hansen, I'm running will-it-scale with parameters

./runtest.py read2 16 1 16 24 32 48 64 8

Which runs both threaded/process tests. The runtest.py is modified to
accept a custom list of threads to run. The patch is attached.

The list of duration and thread numbers for runtest.py are computed
and is different for machines with different number of CPUs. The goal
of the computation is so that the test wall time on different machines
will be equally ~5 minutes.

In a system with 120 CPUs, the numbers will be:

./runtest.py brk1 16 1 120 15 30 45 60 90

Thanks,
Fengguang

[-- Attachment #2: 0001-accept-custom-list-of-threads-to-run.patch --]
[-- Type: text/x-diff, Size: 1323 bytes --]

>From 882d7cdc4387912e1fe6a3c9e4c42cdb0ce78c23 Mon Sep 17 00:00:00 2001
From: Fengguang Wu <fengguang.wu@intel.com>
Date: Fri, 17 Jan 2014 08:11:52 +0800
Subject: [PATCH] accept custom list of threads to run

Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
---
 runtest.py |   13 +++++++------
 1 file changed, 7 insertions(+), 6 deletions(-)

diff --git a/runtest.py b/runtest.py
index 14d2467..8d4a2cf 100755
--- a/runtest.py
+++ b/runtest.py
@@ -1,4 +1,4 @@
-#!/usr/bin/python2
+#!/usr/bin/python
 
 import time
 import subprocess
@@ -48,12 +48,12 @@ class linux_stat():
 		return 1.0 * idle / (idle + busy)
 
 
-duration=5
-
-if len(sys.argv) != 2:
-	print >> sys.stderr, 'Usage: runtest.py <testcase>'
+if len(sys.argv) < 4:
+	print >> sys.stderr, 'Usage: runtest.py <testcase> <duration> <threads...>'
 	sys.exit(1)
 cmd = sys.argv[1]
+duration = int(sys.argv[2])
+threads  = sys.argv[3:]
 
 nr_cores=0
 r = re.compile('^processor')
@@ -87,7 +87,8 @@ if arch == 'ppc64':
 print 'tasks,processes,processes_idle,threads,threads_idle,linear'
 print '0,0,100,0,100,0'
 
-for i in range(1, nr_cores+1):
+for i in threads:
+	i = int(i)
 	c = './%s_processes -t %d -s %d' % (cmd, i, duration)
 	before = linux_stat()
 	pipe = subprocess.Popen(setarch + ' ' + c, shell=True, stdout=subprocess.PIPE).stdout
-- 
1.7.10.4


  reply	other threads:[~2014-01-17  0:26 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-16  3:07 [slub shrink] 0f6934bf16: +191.9% vmstat.system.cs kernel test robot
2014-01-16 19:12 ` Dave Hansen
2014-01-17  0:26   ` Fengguang Wu [this message]
2014-01-17 13:00   ` Fengguang Wu
2014-01-29  8:26   ` Fengguang Wu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140117002601.GB1413@localhost \
    --to=fengguang.wu@intel.com \
    --cc=dave.hansen@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lkp@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).