linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Bjorn Helgaas <bhelgaas@google.com>
To: Joseph Salisbury <joseph.salisbury@canonical.com>
Cc: LKML <linux-kernel@vger.kernel.org>
Subject: Re: [v3.11][v3.12][v3.13][Regression] EISA: Initialize device before its resources
Date: Fri, 17 Jan 2014 10:02:04 -0700	[thread overview]
Message-ID: <20140117170204.GA13939@google.com> (raw)
In-Reply-To: <52D82169.2000107@canonical.com>

On Thu, Jan 16, 2014 at 01:14:01PM -0500, Joseph Salisbury wrote:
> On 01/16/2014 01:12 PM, Bjorn Helgaas wrote:
> > On Thu, Jan 16, 2014 at 10:53 AM, Joseph Salisbury
> > <joseph.salisbury@canonical.com> wrote:
> >> Hi Bjorn,
> >>
> >> A kernel bug was opened against Ubuntu [0].  After a kernel bisect, it
> >> was found the following commit introduced this bug:
> > Sorry about that, and thanks for the report.  Did you mean to include
> > URL for the bug?
> Yes, sorry about that:
> http://pad.lv/1251816

Hi Joseph,

Can you attach the 3.8.0-32-generic config (the one matching the successful
boot at https://launchpadlibrarian.net/156685076/BootDmesg.txt) to the bug?

The only way I can match up the output:

  EISA: Probing bus 0 at eisa.0
  Cannot allocate resource for EISA slot 1
  Cannot allocate resource for EISA slot 2
  Cannot allocate resource for EISA slot 4
  Cannot allocate resource for EISA slot 5
  EISA: Detected 0 cards.

with the code is if we have root->force_probe set, and the only way I see for
that to happen is if we're in the virtual_eisa_root_init() path and
CONFIG_EISA_VLB_PRIMING=y:

  #if defined(CONFIG_ALPHA_JENSEN) || defined(CONFIG_EISA_VLB_PRIMING)
  #define EISA_FORCE_PROBE_DEFAULT 1
  #else
  #define EISA_FORCE_PROBE_DEFAULT 0
  #endif

  static int force_probe = EISA_FORCE_PROBE_DEFAULT;

  virtual_eisa_root_init
    eisa_bus_root.force_probe = force_probe
    eisa_root_register(&eisa_bus_root)
      eisa_probe(root)
	printk("EISA: Probing bus %d at %s")
	if (eisa_request_resources)         
	  printk("EISA: Cannot allocate resource for mainboard")    # we don't see this
	if (eisa_init_device)               
	  eisa_release_resources
	  kfree
	  if (!root->force_probe)           
	    return -ENODEV
	    goto force_probe
	printk("EISA: Mainboard %s detected")       # we don't see this

	force_probe:
	for (i = 1; ...; i++)
	  if (eisa_request_resources(i))
	    printk("Cannot allocate resource for EISA slot %d", i)
	printk("EISA: Detected %d cards")

Bjorn

  reply	other threads:[~2014-01-17 17:02 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-16 17:53 [v3.11][v3.12][v3.13][Regression] EISA: Initialize device before its resources Joseph Salisbury
2014-01-16 18:12 ` Bjorn Helgaas
2014-01-16 18:14   ` Joseph Salisbury
2014-01-17 17:02     ` Bjorn Helgaas [this message]
2014-01-17 19:26       ` Joseph Salisbury
2014-01-17 22:19         ` Bjorn Helgaas
2014-01-18  1:35           ` Joseph Salisbury
2014-01-18 14:37             ` Bjorn Helgaas
2014-01-22 18:00               ` Joseph Salisbury

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140117170204.GA13939@google.com \
    --to=bhelgaas@google.com \
    --cc=joseph.salisbury@canonical.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).