From: Arnd Bergmann <arnd@arndb.de>
To: Marc Carino <marc.ceeeee@gmail.com>
Cc: Christian Daudt <bcm@fixthebug.org>,
Florian Fainelli <f.fainelli@gmail.com>,
Matt Porter <matt.porter@linaro.org>,
Russell King <linux@arm.linux.org.uk>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v4 8/8] ARM: brcmstb: dts: add a reference DTS for Broadcom 7445
Date: Fri, 17 Jan 2014 21:06:55 +0100 [thread overview]
Message-ID: <201401172106.55668.arnd@arndb.de> (raw)
In-Reply-To: <1389986367-4010-9-git-send-email-marc.ceeeee@gmail.com>
On Friday 17 January 2014, Marc Carino wrote:
> + serial@f0406b00 {
> + compatible = "ns16550a";
> + reg = <0x00 0xf0406b00 0x00 0x20>;
> + reg-shift = <2>;
> + reg-io-width = <4>;
> + interrupts = <0 75 0x4>;
> + clock-frequency = <0x4d3f640>;
> + };
> +
> + rdb {
> + #address-cells = <1>;
> + #size-cells = <1>;
> + compatible = "simple-bus";
> + ranges = <0 0x00 0xf0000000 0x1000000>;
> +
> + sun_top_ctrl: syscon@404000 {
> + compatible = "brcm,bcm7445-sun-top-ctrl",
> + "syscon";
> + reg = <0x404000 0x51c>;
> + };
> +
Yes, this looks better, but as a minor comment, the serial device above
should really be part of the rdb bus now, since that encompasses the
0xf0000000 device range.
Arnd
prev parent reply other threads:[~2014-01-17 20:07 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-17 19:19 [PATCH v4 0/8] ARM: brcmstb: Add Broadcom STB SoC support Marc Carino
2014-01-17 19:19 ` [PATCH v4 1/8] ARM: brcmstb: add infrastructure for ARM-based Broadcom STB SoCs Marc Carino
2014-01-17 19:19 ` [PATCH v4 2/8] power: reset: Add reboot driver for brcmstb Marc Carino
2014-01-17 19:19 ` [PATCH v4 3/8] ARM: brcmstb: add debug UART for earlyprintk support Marc Carino
2014-01-17 19:24 ` Alexander Shiyan
2014-01-17 19:19 ` [PATCH v4 4/8] ARM: do CPU-specific init for Broadcom Brahma15 cores Marc Carino
2014-01-17 19:19 ` [PATCH v4 5/8] ARM: brcmstb: add CPU binding for Broadcom Brahma15 Marc Carino
2014-01-17 19:19 ` [PATCH v4 6/8] ARM: brcmstb: add misc. DT bindings for brcmstb Marc Carino
2014-01-17 19:19 ` [PATCH v4 7/8] ARM: brcmstb: gic: add compatible string for Broadcom Brahma15 Marc Carino
2014-01-17 19:19 ` [PATCH v4 8/8] ARM: brcmstb: dts: add a reference DTS for Broadcom 7445 Marc Carino
2014-01-17 20:06 ` Arnd Bergmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201401172106.55668.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=bcm@fixthebug.org \
--cc=devicetree@vger.kernel.org \
--cc=f.fainelli@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=marc.ceeeee@gmail.com \
--cc=matt.porter@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox