From: Dan Carpenter <dan.carpenter@oracle.com>
To: Surendra Patil <surendra.tux@gmail.com>
Cc: gregkh@linuxfoundation.org, devel@driverdev.osuosl.org,
abbotti@mev.co.uk, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Staging : comedi : comedidev.h Fixed warning space coding style issue
Date: Mon, 20 Jan 2014 12:09:33 +0300 [thread overview]
Message-ID: <20140120090933.GU7444@mwanda> (raw)
In-Reply-To: <1390205949-12102-1-git-send-email-surendra.tux@gmail.com>
On Mon, Jan 20, 2014 at 12:19:09AM -0800, Surendra Patil wrote:
> Fixed a coding style issue,removed space after the function pointer name
>
> Signed-off-by: Surendra Patil <surendra.tux@gmail.com>
> ---
> drivers/staging/comedi/comedidev.h | 32 ++++++++++++++++----------------
> 1 file changed, 16 insertions(+), 16 deletions(-)
>
> diff --git a/drivers/staging/comedi/comedidev.h b/drivers/staging/comedi/comedidev.h
> index f82bd42..588e9e7 100644
> --- a/drivers/staging/comedi/comedidev.h
> +++ b/drivers/staging/comedi/comedidev.h
> @@ -61,29 +61,29 @@ struct comedi_subdevice {
>
> unsigned int *chanlist; /* driver-owned chanlist (not used) */
>
> - int (*insn_read) (struct comedi_device *, struct comedi_subdevice *,
> + int (*insn_read)(struct comedi_device *, struct comedi_subdevice *,
> struct comedi_insn *, unsigned int *);
Now the the second line has one extra space. The 's' characters in
"struct comedi_device *" and "struct comedi_insn *" should be on the
same column.
regards,
dan carpenter
prev parent reply other threads:[~2014-01-20 9:09 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-20 8:19 [PATCH] Staging : comedi : comedidev.h Fixed warning space coding style issue Surendra Patil
2014-01-20 9:09 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140120090933.GU7444@mwanda \
--to=dan.carpenter@oracle.com \
--cc=abbotti@mev.co.uk \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=surendra.tux@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox