From: Matthew Garrett <mjg59@srcf.ucam.org>
To: Souvik Banerjee <souvik1997@gmail.com>
Cc: linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] dell-wmi: Add KEY_SWITCHVIDEOMODE for Dell N4110.
Date: Mon, 20 Jan 2014 16:37:01 +0000 [thread overview]
Message-ID: <20140120163701.GA6312@srcf.ucam.org> (raw)
In-Reply-To: <52DD4F74.4000807@gmail.com>
On Mon, Jan 20, 2014 at 10:31:48AM -0600, Souvik Banerjee wrote:
> I used KE_KEY instead of KE_IGNORE. Should it be changed to KE_IGNORE?
> On my kernel build with KE_KEY everything works as expected, but I have
> not tried it with KE_IGNORE.
KE_KEY means that dell-wmi will report the key. If it's also being
reported via the keyboard controller then it should be KE_IGNORE
instead.
--
Matthew Garrett | mjg59@srcf.ucam.org
next prev parent reply other threads:[~2014-01-20 16:37 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-20 15:28 [PATCH] dell-wmi: Add KEY_SWITCHVIDEOMODE for Dell N4110 Souvik Banerjee
2014-01-20 15:31 ` Matthew Garrett
[not found] ` <52DD492F.1060208@gmail.com>
2014-01-20 16:06 ` Souvik Banerjee
[not found] ` <20140120161132.GC3844@srcf.ucam.org>
2014-01-20 16:31 ` Souvik Banerjee
2014-01-20 16:37 ` Matthew Garrett [this message]
2014-01-20 16:46 ` Souvik Banerjee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140120163701.GA6312@srcf.ucam.org \
--to=mjg59@srcf.ucam.org \
--cc=linux-kernel@vger.kernel.org \
--cc=souvik1997@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).