From: Andi Kleen <andi@firstfloor.org>
To: Arnaldo Carvalho de Melo <acme@ghostprotocols.net>
Cc: Stanislav Fomichev <stfomichev@yandex-team.ru>,
a.p.zijlstra@chello.nl, paulus@samba.org, mingo@redhat.com,
namhyung@kernel.org, jolsa@redhat.com, dsahern@gmail.com,
adrian.hunter@intel.com, linux-kernel@vger.kernel.org,
Andi Kleen <andi@firstfloor.org>
Subject: Re: [PATCH 3/3] perf tools: bring back old behavior when NO_DEMAGLE doesn't link with libbfd
Date: Mon, 20 Jan 2014 18:19:52 +0100 [thread overview]
Message-ID: <20140120171952.GS20765@two.firstfloor.org> (raw)
In-Reply-To: <20140120132225.GA18862@ghostprotocols.net>
On Mon, Jan 20, 2014 at 10:22:25AM -0300, Arnaldo Carvalho de Melo wrote:
> Em Mon, Jan 20, 2014 at 03:39:40PM +0400, Stanislav Fomichev escreveu:
> > This commit reverts part of the 3e6a147deef9 "perf tools: Separate lbfd
> > check out of NO_DEMANGLE condition" which always links perf with libbfd.
> > I'd like to preserve old behavior when NO_DEMAGLE does not link with
> > it, because some machines may contain different versions of binutils
> > (hence miss required libbfd version) and I still want an option to build perf
> > which works on any machine regardless of binutils version.
BFD is not only used for demangling, it's also used for decoding
source lines now. So tying it only to NO_DEMANGLE would not be correct.
-Andi
prev parent reply other threads:[~2014-01-20 17:19 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-20 11:39 [PATCH 0/3] perf fixes Stanislav Fomichev
2014-01-20 11:39 ` [PATCH 1/3] perf timechart: fix wrong SVG height Stanislav Fomichev
2014-01-23 17:03 ` [tip:perf/urgent] perf timechart: Fix " tip-bot for Stanislav Fomichev
2014-01-20 11:39 ` [PATCH 2/3] perf util: free cpu_map in perf_session__cpu_bitmap Stanislav Fomichev
2014-01-23 17:03 ` [tip:perf/urgent] perf session: Free " tip-bot for Stanislav Fomichev
2014-01-20 11:39 ` [PATCH 3/3] perf tools: bring back old behavior when NO_DEMAGLE doesn't link with libbfd Stanislav Fomichev
2014-01-20 13:22 ` Arnaldo Carvalho de Melo
2014-01-20 17:19 ` Andi Kleen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140120171952.GS20765@two.firstfloor.org \
--to=andi@firstfloor.org \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@ghostprotocols.net \
--cc=adrian.hunter@intel.com \
--cc=dsahern@gmail.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=paulus@samba.org \
--cc=stfomichev@yandex-team.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).