public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Rashika Kheria <rashika.kheria@gmail.com>
Cc: linux-kernel@vger.kernel.org, devel@driverdev.osuosl.org,
	"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
	josh@joshtriplett.org, "Tülin İzer" <tulinizer@gmail.com>,
	"Michael Banken" <michael.banken@mathe.stud.uni-erlangen.de>,
	"Al Viro" <viro@zeniv.linux.org.uk>
Subject: Re: [PATCH] drivers: staging: Mark functions as static and remove unused function in bpctl_mod.c
Date: Fri, 24 Jan 2014 11:04:51 +0300	[thread overview]
Message-ID: <20140124080451.GD7444@mwanda> (raw)
In-Reply-To: <20140123224400.GA8124@rashika>

On Fri, Jan 24, 2014 at 04:14:00AM +0530, Rashika Kheria wrote:
> Mark functions as static in bpctl_mod.c because they are not used
> outside this file. Remove unused function from bpctl_mod.c.
> 
> This also eliminates the following warnings from bpctl_mod.c:
> drivers/staging/silicom/bpctl_mod.c:1507:6: warning: no previous prototype for ‘send_bypass_clear_pulse’ [-Wmissing-prototypes]
> drivers/staging/silicom/bpctl_mod.c:1762:5: warning: no previous prototype for ‘cmnd_on’ [-Wmissing-prototypes]

Don't do these massive text blocks.  Just put one or two of the errors
so we get the idea.

regards,
dan carpenter


  reply	other threads:[~2014-01-24  8:05 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-23 22:44 [PATCH] drivers: staging: Mark functions as static and remove unused function in bpctl_mod.c Rashika Kheria
2014-01-24  8:04 ` Dan Carpenter [this message]
2014-01-24  8:22   ` Rashika Kheria
2014-01-25 10:30 ` Josh Triplett

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140124080451.GD7444@mwanda \
    --to=dan.carpenter@oracle.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=josh@joshtriplett.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=michael.banken@mathe.stud.uni-erlangen.de \
    --cc=rashika.kheria@gmail.com \
    --cc=tulinizer@gmail.com \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox