public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@kernel.org>
To: Aaron Tomlin <atomlin@redhat.com>
Cc: linux-kernel@vger.kernel.org, rientjes@google.com,
	mingo@redhat.com, oleg@redhat.com, riel@redhat.com,
	akpm@linux-foundation.org
Subject: Re: [RFC PATCH v5 1/2] sysctl: Make neg_one a standard constraint
Date: Sat, 25 Jan 2014 09:58:36 +0100	[thread overview]
Message-ID: <20140125085836.GB16070@gmail.com> (raw)
In-Reply-To: <20140125084800.GA16070@gmail.com>


* Ingo Molnar <mingo@kernel.org> wrote:

> 
> * Aaron Tomlin <atomlin@redhat.com> wrote:
> 
> > Add neg_one to the list of standard constraints.
> > 
> > Signed-off-by: Aaron Tomlin <atomlin@redhat.com>
> > Acked-by: Rik van Riel <riel@redhat.com>
> > Acked-by: David Rientjes <rientjes@google.com>
> > ---
> >  kernel/sysctl.c | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/kernel/sysctl.c b/kernel/sysctl.c
> > index 34a6047..dd531a6 100644
> > --- a/kernel/sysctl.c
> > +++ b/kernel/sysctl.c
> > @@ -122,6 +122,7 @@ extern int blk_iopoll_enabled;
> >  static int sixty = 60;
> >  #endif
> >  
> > +static int neg_one = -1;
> >  static int zero;
> >  static int __maybe_unused one = 1;
> >  static int __maybe_unused two = 2;
> 
> So what happens if CONFIG_DETECT_HUNG_TASK is not defined and 
> neg_one is unused? The compiler generates an unused variable 
> warning.

Note, I fixed this up in your patch, no need to resend.

Thanks,

	Ingo

  reply	other threads:[~2014-01-25  8:58 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-23 10:56 [RFC PATCH v5 0/2] hung_task: Display every hung task warning Aaron Tomlin
2014-01-23 10:56 ` [RFC PATCH v5 1/2] sysctl: Make neg_one a standard constraint Aaron Tomlin
2014-01-25  8:48   ` Ingo Molnar
2014-01-25  8:58     ` Ingo Molnar [this message]
2014-01-23 10:56 ` [RFC PATCH v5 2/2] hung_task: Display every hung task warning Aaron Tomlin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140125085836.GB16070@gmail.com \
    --to=mingo@kernel.org \
    --cc=akpm@linux-foundation.org \
    --cc=atomlin@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=oleg@redhat.com \
    --cc=riel@redhat.com \
    --cc=rientjes@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox