From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751998AbaAYI6l (ORCPT ); Sat, 25 Jan 2014 03:58:41 -0500 Received: from mail-ee0-f50.google.com ([74.125.83.50]:55939 "EHLO mail-ee0-f50.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751178AbaAYI6j (ORCPT ); Sat, 25 Jan 2014 03:58:39 -0500 Date: Sat, 25 Jan 2014 09:58:36 +0100 From: Ingo Molnar To: Aaron Tomlin Cc: linux-kernel@vger.kernel.org, rientjes@google.com, mingo@redhat.com, oleg@redhat.com, riel@redhat.com, akpm@linux-foundation.org Subject: Re: [RFC PATCH v5 1/2] sysctl: Make neg_one a standard constraint Message-ID: <20140125085836.GB16070@gmail.com> References: <1390474563-15424-1-git-send-email-atomlin@redhat.com> <1390474563-15424-2-git-send-email-atomlin@redhat.com> <20140125084800.GA16070@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20140125084800.GA16070@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Ingo Molnar wrote: > > * Aaron Tomlin wrote: > > > Add neg_one to the list of standard constraints. > > > > Signed-off-by: Aaron Tomlin > > Acked-by: Rik van Riel > > Acked-by: David Rientjes > > --- > > kernel/sysctl.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/kernel/sysctl.c b/kernel/sysctl.c > > index 34a6047..dd531a6 100644 > > --- a/kernel/sysctl.c > > +++ b/kernel/sysctl.c > > @@ -122,6 +122,7 @@ extern int blk_iopoll_enabled; > > static int sixty = 60; > > #endif > > > > +static int neg_one = -1; > > static int zero; > > static int __maybe_unused one = 1; > > static int __maybe_unused two = 2; > > So what happens if CONFIG_DETECT_HUNG_TASK is not defined and > neg_one is unused? The compiler generates an unused variable > warning. Note, I fixed this up in your patch, no need to resend. Thanks, Ingo