Re: [PATCH] Use realpath for srctree and objtree

[Jiri Olsa <jolsa@redhat.com>]

On Sun, Jan 26, 2014 at 06:06:18PM +0800, Wang Nan wrote:
> When BUILD_SRC contains a tailing '/', the file name used in compiling command
> will contain '//', and it then goes to .o's debuginfo, confuses debugedit:
> 
> https://bugzilla.redhat.com/show_bug.cgi?id=304121
> 
> This patch uses realpath to makesure srctree and objtree don't have tailing '/'.
> 
> Signed-off-by: Wang Nan <wangnan0@huawei.com>
> Cc: Sasha Levin <sasha.levin@oracle.com>
> Cc: Arnaldo Carvalho de Melo <acme@redhat.com>
> Cc: Jiri Olsa <jolsa@redhat.com>
> Cc: Steven Rostedt <rostedt@goodmis.org>
> Cc: Namhyung Kim <namhyung@kernel.org>
> Cc: Geng Hui <hui.geng@huawei.com>
> 
> ---
>  tools/lib/lockdep/Makefile    | 4 ++--
>  tools/lib/traceevent/Makefile | 4 ++--
>  2 files changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/tools/lib/lockdep/Makefile b/tools/lib/lockdep/Makefile
> index da8b7aa..e638dd5 100644
> --- a/tools/lib/lockdep/Makefile
> +++ b/tools/lib/lockdep/Makefile
> @@ -87,8 +87,8 @@ endif # BUILD_SRC
>  # We process the rest of the Makefile if this is the final invocation of make
>  ifeq ($(skip-makefile),)
>  
> -srctree		:= $(if $(BUILD_SRC),$(BUILD_SRC),$(CURDIR))
> -objtree		:= $(CURDIR)
> +srctree		:= $(realpath $(if $(BUILD_SRC),$(BUILD_SRC),$(CURDIR)))
> +objtree		:= $(realpath $(CURDIR))
>  src		:= $(srctree)
>  obj		:= $(objtree)
>  
> diff --git a/tools/lib/traceevent/Makefile b/tools/lib/traceevent/Makefile
> index 56d52a3..dd23171 100644
> --- a/tools/lib/traceevent/Makefile
> +++ b/tools/lib/traceevent/Makefile
> @@ -107,8 +107,8 @@ endif # BUILD_SRC
>  # We process the rest of the Makefile if this is the final invocation of make
>  ifeq ($(skip-makefile),)
>  
> -srctree		:= $(if $(BUILD_SRC),$(BUILD_SRC),$(CURDIR))
> -objtree		:= $(CURDIR)
> +srctree		:= $(realpath $(if $(BUILD_SRC),$(BUILD_SRC),$(CURDIR)))
> +objtree		:= $(realpath $(CURDIR))
>  src		:= $(srctree)
>  obj		:= $(objtree)

ack for the traceevent change

thanks,
jirka