From: Fengguang Wu <fengguang.wu@intel.com>
To: Ming Lei <tom.leiming@gmail.com>
Cc: LKML <linux-kernel@vger.kernel.org>, Hugh Dickins <hughd@google.com>
Subject: Re: [percpu_counter] 74e72f894: -47.6% aim7 jobs-per-min
Date: Mon, 27 Jan 2014 20:23:58 +0800 [thread overview]
Message-ID: <20140127122358.GA8166@localhost> (raw)
In-Reply-To: <CACVXFVNRvPRXF9VL-b+0iGE9XETwmTZ-JEmdxRGdovRamLnaGQ@mail.gmail.com>
Hi Ming Lei,
On Fri, Jan 17, 2014 at 06:56:24PM +0800, Ming Lei wrote:
> Hi Fengguang,
>
> On Fri, Jan 17, 2014 at 6:20 PM, Fengguang Wu <fengguang.wu@intel.com> wrote:
> > Ming Lei,
> >
> > We noticed that commit 74e72f894 ("lib/percpu_counter.c: fix
> > __percpu_counter_add()") introduces -47.6% regression in aim7 brk_test
> > on a 2S SNB server. Comparing to its parent commit:
>
> The commit has a bug, could you apply Hugh's patch[1] to test if
> the regression can be fixed?
>
> If the performance regression is still there, it may be caused by bad
> performance of this_cpu_add(), then I suggest you to test the patch[2]
> too without enabling lockdep.
>
>
> [1], http://marc.info/?t=138991497900001&r=1&w=2
Hugh's patch is enough to fix the kernel oops and performance regressions:
74e72f894d56eb9 0ddc13035a9b3679a0e1a2cec
--------------- -------------------------
1 ~ 0% -100.0% 0 vpx/micro/xfstests/4HDD-ext4-generic-slow2
1 ~ 0% -100.0% 0 TOTAL dmesg.This_should_not_happen_Data_will_be_lost
74e72f894d56eb9 0ddc13035a9b3679a0e1a2cec
--------------- -------------------------
71965 ~ 0% +90.4% 137038 ~ 0% lkp-snb01/micro/aim7/brk_test
71965 ~ 0% +90.4% 137038 ~ 0% TOTAL aim7.2000.jobs-per-min
In fact it turns regression to noticeable performance increase. :)
Thanks,
Fengguang
> [2], http://marc.info/?l=linux-kernel&m=138909074202090&w=2
>
> Thanks,
> --
> Ming Lei
prev parent reply other threads:[~2014-01-27 12:24 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-17 10:20 [percpu_counter] 74e72f894: -47.6% aim7 jobs-per-min Fengguang Wu
2014-01-17 10:56 ` Ming Lei
2014-01-27 12:23 ` Fengguang Wu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140127122358.GA8166@localhost \
--to=fengguang.wu@intel.com \
--cc=hughd@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tom.leiming@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox