From: Jens Axboe <axboe@kernel.dk>
To: Christoph Hellwig <hch@infradead.org>
Cc: linux-kernel@vger.kernel.org
Subject: Re: ipi_redirect vs rq_affinity
Date: Mon, 27 Jan 2014 12:16:56 -0700 [thread overview]
Message-ID: <20140127191656.GD2782@kernel.dk> (raw)
In-Reply-To: <20140127075158.GB18590@infradead.org>
On Sun, Jan 26 2014, Christoph Hellwig wrote:
> On Fri, Jan 24, 2014 at 11:11:29AM -0800, Jens Axboe wrote:
> > It is pretty much the same. I don't like the semantics of the old one,
> > where it's 0/1/2 for off/on/different-on, though. Seems like now would
> > be a good time to clean it up.
>
> I don't think arbitrarily breaking this fairly widely used interface
> when a driver is moving to blk-mq sounds like a good idea. Maybe we
> should allow for setting descriptive strings as well?
Yeah, that's a good idea. We could retain the 0/1/2 for compat reasons,
but have it present strings instead.
> Also the different on semantics do matter for some use cases, and we
> should support both for blk-mq.
Certainly, not disagreeing with that.
--
Jens Axboe
prev parent reply other threads:[~2014-01-27 19:16 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-24 13:22 ipi_redirect vs rq_affinity Christoph Hellwig
2014-01-24 19:11 ` Jens Axboe
2014-01-27 7:51 ` Christoph Hellwig
2014-01-27 19:16 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140127191656.GD2782@kernel.dk \
--to=axboe@kernel.dk \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox