From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755072AbaA1JhG (ORCPT ); Tue, 28 Jan 2014 04:37:06 -0500 Received: from cantor2.suse.de ([195.135.220.15]:54294 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755051AbaA1JhC (ORCPT ); Tue, 28 Jan 2014 04:37:02 -0500 Date: Tue, 28 Jan 2014 10:37:01 +0100 From: Michal Hocko To: Borislav Petkov Cc: "H. Peter Anvin" , Ingo Molnar , Thomas Gleixner , Jiri Kosina , Michael Matz , lkml , Ralf Baechle Subject: Re: [RFC] x86: Disable traditional FPU instructions too Message-ID: <20140128093701.GC2221@dhcp22.suse.cz> References: <20140127163758.GC6839@pd.tnic> <52E68C25.1070804@zytor.com> <20140127164544.GE6839@pd.tnic> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20140127164544.GE6839@pd.tnic> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org [CCing Ralf for MIPS.] On Mon 27-01-14 17:45:44, Borislav Petkov wrote: > On Mon, Jan 27, 2014 at 08:41:09AM -0800, H. Peter Anvin wrote: > > I don't think it'd hurt... although I think the above pretty much > > requires that the code contain actual floating-point types to ever be > > generated. > > Yes, that is supposed to catch usage of the 'E' floating constant, for > example, in definitions. It is a build-time assertion, if you want. :) And git grep says that mips abuses this notation: arch/mips/include/asm/kvm_host.h:#define MS_TO_NS(x) (x * 1E6L) I do not have cross-compiler set up to check whether this is a real issue because include/media/rc-core.h defines the same macro correctly so the real code might end up using the right variant. -- Michal Hocko SUSE Labs