From: Marcelo Tosatti <mtosatti@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: linux-kernel@vger.kernel.org, gleb@kernel.org, hpa@zytor.com,
mingo@redhat.com, tglx@linutronix.de
Subject: Re: [PATCH 0/2] x86, kvm: fix detection of KVM features when KVM and Hyper-V coexist
Date: Tue, 28 Jan 2014 20:19:01 -0200 [thread overview]
Message-ID: <20140128221901.GA3096@amt.cnet> (raw)
In-Reply-To: <1390846290-26844-1-git-send-email-pbonzini@redhat.com>
On Mon, Jan 27, 2014 at 07:11:28PM +0100, Paolo Bonzini wrote:
> When KVM also presents Hyper-V features (which is useful because Windows
> behaves better), Linux guests prefer KVM because emulated leaves are at
> 0x40000000 and the native ones are at 0x40000100.
>
> However, Linux is then not accounting for the offset when reading the
> available hypervisor features from CPUID. Instead of looking at
> 0x40000101, it will always look at 0x40000001.
>
> This series makes sure that features such as async page faults or steal
> time are available even if, for whatever reason, Hyper-V features are
> enabled.
>
> As a side effect, patch 1 makes a bunch of code non inline, which also
> makes sense since it should only be called during initialization. As
> a result, vmlinux .text size decreases by 96 bytes.
>
> Please review!
>
> Paolo Bonzini (2):
> x86, kvm: cache the base of the KVM cpuid leaves
> x86, kvm: correctly access the KVM_CPUID_FEATURES leaf at 0x40000101
>
> arch/x86/include/asm/kvm_para.h | 33 ++++++++++++---------------------
> arch/x86/kernel/kvm.c | 31 +++++++++++++++++++++++++++++++
> 2 files changed, 43 insertions(+), 21 deletions(-)
>
> --
> 1.8.3.1
Reviewed-by: Marcelo Tosatti <mtosatti@redhat.com>
prev parent reply other threads:[~2014-01-28 22:20 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-27 18:11 [PATCH 0/2] x86, kvm: fix detection of KVM features when KVM and Hyper-V coexist Paolo Bonzini
2014-01-27 18:11 ` [PATCH 1/2] x86, kvm: cache the base of the KVM cpuid leaves Paolo Bonzini
2014-01-27 18:11 ` [PATCH 2/2] x86, kvm: correctly access the KVM_CPUID_FEATURES leaf at 0x40000101 Paolo Bonzini
2014-01-28 22:19 ` Marcelo Tosatti [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140128221901.GA3096@amt.cnet \
--to=mtosatti@redhat.com \
--cc=gleb@kernel.org \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=pbonzini@redhat.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox