From: Jenny Tc <jenny.tc@intel.com>
To: Pavel Machek <pavel@ucw.cz>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Dmitry Eremin-Solenikov <dbaryshkov@gmail.com>,
Anton Vorontsov <cbouatmailru@gmail.com>,
Anton Vorontsov <anton.vorontsov@linaro.org>,
Kim Milo <Milo.Kim@ti.com>, Lee Jones <lee.jones@linaro.org>,
Jingoo Han <jg1.han@samsung.com>,
Chanwoo Choi <cw00.choi@samsung.com>,
Sachin Kamat <sachin.kamat@linaro.org>,
Rupesh Kumar <rupesh.kumar@stericsson.com>,
Lars-Peter Clausen <lars@metafoo.de>,
Pali Roh?r <pali.rohar@gmail.com>,
Mark Brown <broonie@opensource.wolfsonmicro.com>,
Rhyland Klein <rklein@nvidia.com>,
David Woodhouse <dwmw2@infradead.org>,
Tony Lindgren <tony@atomide.com>,
Russell King <linux@arm.linux.org.uk>,
Sebastian Reichel <sre@ring0.de>,
"aaro.koskinen@iki.fi" <aaro.koskinen@iki.fi>,
"freemangordon@abv.bg" <freemangordon@abv.bg>,
"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>
Subject: Re: [PATCH 2/4] power_supply: Introduce Generic Power Supply charging driver
Date: Thu, 30 Jan 2014 00:43:24 +0530 [thread overview]
Message-ID: <20140129191324.GC15355@jenny-desktop> (raw)
In-Reply-To: <20140125170402.GA27959@Nokia-N900>
On Sat, Jan 25, 2014 at 10:04:03AM -0700, Pavel Machek wrote:
> > + * Write access using set_property
> > + * Set Maximum charging current
> > + * Action: Configure safety charging registers if any. If not no
> > + actions expected for this.
>
> Having property that does nothing sounds evil to me.
No h/w actions expected. But driver action expected. Will fix in next patch set
> > +* POWER_SUPPLY_CHARGER_PROP_ENABLE_CHARGING
> > + * Write access using set_property
> > + * Enable/Disable charging. Charger supplies power to platform,
> > + but charging is disabled
>
> This is unclear. Charging is always disabled?
Writing 0, disables charger. Writing 1 enables charging.
-Jenny
next prev parent reply other threads:[~2014-01-29 11:21 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-22 17:19 [PATCH v3 0/4] power_supply: Introduce power supply charging driver Jenny TC
2014-01-22 17:19 ` [PATCH 1/4] power_supply: Add inlmt,iterm, min/max temp props Jenny TC
2014-01-23 9:00 ` Jingoo Han
2014-01-24 13:01 ` Pavel Machek
2014-01-24 15:25 ` Dmitry Eremin-Solenikov
2014-01-29 13:08 ` Jenny Tc
2014-01-22 17:19 ` [PATCH 2/4] power_supply: Introduce Generic Power Supply charging driver Jenny TC
2014-01-25 17:04 ` Pavel Machek
2014-01-29 19:13 ` Jenny Tc [this message]
2014-01-22 17:19 ` [PATCH 3/4] power_supply: Introduce PSE compliant algorithm Jenny TC
2014-01-25 22:29 ` Pavel Machek
2014-01-22 17:19 ` [PATCH 4/4] power_supply: bq24261 charger driver Jenny TC
2014-01-23 8:58 ` Jingoo Han
2014-01-25 22:30 ` Pavel Machek
2014-01-28 14:14 ` Pavel Machek
2014-01-29 13:23 ` Jenny Tc
2014-01-29 7:26 ` Jingoo Han
2014-01-29 9:36 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140129191324.GC15355@jenny-desktop \
--to=jenny.tc@intel.com \
--cc=Milo.Kim@ti.com \
--cc=aaro.koskinen@iki.fi \
--cc=anton.vorontsov@linaro.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=cbouatmailru@gmail.com \
--cc=cw00.choi@samsung.com \
--cc=dbaryshkov@gmail.com \
--cc=dwmw2@infradead.org \
--cc=freemangordon@abv.bg \
--cc=jg1.han@samsung.com \
--cc=lars@metafoo.de \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=pali.rohar@gmail.com \
--cc=pavel@ucw.cz \
--cc=rklein@nvidia.com \
--cc=rupesh.kumar@stericsson.com \
--cc=sachin.kamat@linaro.org \
--cc=sre@ring0.de \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox