From: Ingo Molnar <mingo@kernel.org>
To: Mathias Krause <minipli@googlemail.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
"H. Peter Anvin" <hpa@zytor.com>,
Richard Weinberger <richard@nod.at>,
"H. Peter Anvin" <hpa@linux.intel.com>,
Kees Cook <keescook@chromium.org>, Cong Ding <dinggnu@gmail.com>,
Ingo Molnar <mingo@elte.hu>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Michael Davidson <md@google.com>,
Thomas Gleixner <tglx@linutronix.de>,
Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Subject: Re: [GIT PULL] x86/kaslr for v3.14
Date: Thu, 30 Jan 2014 10:23:02 +0100 [thread overview]
Message-ID: <20140130092301.GB2862@gmail.com> (raw)
In-Reply-To: <CA+rthh93phituM24W8KrGygvKtUmByJUtOCS-sELj4QgLqS3cw@mail.gmail.com>
* Mathias Krause <minipli@googlemail.com> wrote:
> On 29 January 2014 09:11, Ingo Molnar <mingo@kernel.org> wrote:
> >> But you can see that the symbol is perfectly fine:
> >>
> >> (gdb) list *(schedule+0x45)
> >
> > Oh, cool. Thanks for that trick - this will save me quite some time in
> > the future.
> >
> > So we can strip absolute addresses just fine from oopses - cool.
> >
> > I'd even argue to strip the hex on non-randomized kernels as long as
> > there's kallsyms around, and only print hex if we don't have any
> > symbols.
>
> Please, don't do so! I do find the hex values in the backtrace
> *very* useful as I'm using 'objdump -wdr vmlinux | less' quite often
> to "browse around" in the kernel binary. Grepping for addresses from
> a backtrace works quite nicely this way. Having to lookup symbols
> and do base-16 arithmetics in the head (or a shell, for that matter)
> would only slow down this process. So, please leave the hex values
> in place. They do help a lot -- at least in the non-kASLR case.
Well, if the consensus is that they help then we better make them
correct in the KASLR case as well ...
Thanks,
Ingo
next prev parent reply other threads:[~2014-01-30 9:23 UTC|newest]
Thread overview: 70+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-20 16:47 [GIT PULL] x86/kaslr for v3.14 H. Peter Anvin
2014-01-20 22:54 ` Linus Torvalds
2014-01-20 23:00 ` H. Peter Anvin
2014-01-20 23:12 ` Linus Torvalds
2014-01-20 23:13 ` H. Peter Anvin
2014-01-21 9:00 ` Peter Zijlstra
2014-01-21 14:20 ` H. Peter Anvin
2014-01-21 14:39 ` Ingo Molnar
2014-01-21 14:51 ` H. Peter Anvin
2014-01-21 14:56 ` Ingo Molnar
2014-01-21 18:37 ` Kees Cook
2014-01-21 10:27 ` Ingo Molnar
2014-01-21 13:55 ` H. Peter Anvin
2014-01-21 14:03 ` Ingo Molnar
2014-01-21 14:05 ` H. Peter Anvin
2014-01-21 14:14 ` Ingo Molnar
2014-01-21 14:17 ` H. Peter Anvin
2014-01-21 5:18 ` Kees Cook
2014-01-23 9:39 ` Pavel Machek
2014-01-26 10:16 ` Richard Weinberger
2014-01-27 5:33 ` H. Peter Anvin
2014-01-27 6:49 ` Richard Weinberger
2014-01-27 6:51 ` H. Peter Anvin
2014-01-27 7:38 ` Ingo Molnar
2014-01-27 7:43 ` Ingo Molnar
2014-01-27 7:59 ` Richard Weinberger
2014-01-30 22:07 ` Vivek Goyal
2014-01-31 16:57 ` Kees Cook
2014-02-07 14:49 ` Vivek Goyal
2014-02-07 16:04 ` H. Peter Anvin
2014-02-07 16:24 ` Vivek Goyal
2014-02-07 23:16 ` Dave Young
2014-02-07 23:20 ` H. Peter Anvin
2014-02-07 23:28 ` Dave Young
2014-02-07 19:07 ` H. Peter Anvin
2014-02-07 19:44 ` Kees Cook
2014-01-27 6:52 ` H. Peter Anvin
2014-01-27 7:34 ` Richard Weinberger
2014-01-27 17:05 ` Kees Cook
2014-01-27 17:20 ` Richard Weinberger
2014-01-27 17:24 ` Kees Cook
2014-01-28 6:28 ` Ingo Molnar
2014-01-28 8:25 ` Richard Weinberger
2014-01-28 15:55 ` H. Peter Anvin
2014-01-28 16:25 ` Richard Weinberger
2014-01-28 16:30 ` H. Peter Anvin
2014-01-28 16:51 ` Linus Torvalds
2014-01-28 17:05 ` Ingo Molnar
2014-01-28 17:12 ` Linus Torvalds
2014-01-28 17:24 ` Richard Weinberger
2014-01-28 17:35 ` Linus Torvalds
2014-01-28 17:52 ` Richard Weinberger
2014-01-28 17:56 ` Linus Torvalds
2014-01-28 18:54 ` Richard Weinberger
2014-01-28 19:48 ` Ingo Molnar
2014-01-28 20:07 ` Linus Torvalds
2014-01-28 20:15 ` Borislav Petkov
2014-01-28 20:25 ` Linus Torvalds
2014-01-28 20:28 ` Richard Weinberger
2014-01-28 20:38 ` H. Peter Anvin
2014-01-29 8:25 ` Ingo Molnar
2014-01-29 10:40 ` Borislav Petkov
2014-01-28 20:49 ` Borislav Petkov
2014-01-28 23:37 ` Borislav Petkov
2014-01-28 21:08 ` Dave Jones
2014-01-29 6:36 ` Mike Galbraith
2014-01-29 8:11 ` Ingo Molnar
2014-01-29 8:27 ` Mathias Krause
2014-01-30 9:23 ` Ingo Molnar [this message]
2014-01-30 18:15 ` Linus Torvalds
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140130092301.GB2862@gmail.com \
--to=mingo@kernel.org \
--cc=dinggnu@gmail.com \
--cc=hpa@linux.intel.com \
--cc=hpa@zytor.com \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=md@google.com \
--cc=mingo@elte.hu \
--cc=minipli@googlemail.com \
--cc=richard@nod.at \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
--cc=yongjun_wei@trendmicro.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).