Re: [PATCH 9/9] sched: Push down pre_schedule() and idle_balance()

Peter Zijlstra
2014-01-30T15:22:15Z

On Thu, Jan 30, 2014 at 01:45:07PM +0100, Vincent Guittot wrote:
> On 28 January 2014 18:16, Peter Zijlstra <peterz@infradead.org> wrote:
> > +idle:
> > + idle_exit_fair(rq);
>
> It should be idle_enter_fair.
>
> we want to update the statistic with the running time of other classes
> than CFS.
>
> The use case is:
>
> exit idle
> put_prev_task_idle
> --> idle_exit_fair (account elapsed idle time)
> pick_next_task other than fair tasks
> switch between "other than fair" tasks
> ...
> no more "other than fair" tasks to schedule
> pick_next_task_fair
> --> no fair task on the rq
> --> jump to simple
> --> idle_enter_fair (account elapsed running time of other class
> before trying to pull fair task from other CPUs)
> --> idle_balance()
> ...

Right.. terminal confusion on this topic it seems. Fixed it up.