From: Dave Jones <davej@redhat.com>
To: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Cc: daniel.vetter@ffwll.ch, airlied@redhat.com
Subject: Re: drm: restrict the device list for shadow attached drivers
Date: Thu, 30 Jan 2014 11:41:51 -0500 [thread overview]
Message-ID: <20140130164151.GA24574@redhat.com> (raw)
In-Reply-To: <20140130045754.7E5C1660D2B@gitolite.kernel.org>
On Thu, Jan 30, 2014 at 04:57:54AM +0000, Linux Kernel wrote:
> Gitweb: http://git.kernel.org/linus/;a=commit;h=b3f2333de8e81b089262b26d52272911523e605f
> Commit: b3f2333de8e81b089262b26d52272911523e605f
> Parent: e2577d455adb165e1046816e5ed092cc6d60f35a
> Author: Daniel Vetter <daniel.vetter@ffwll.ch>
> AuthorDate: Wed Dec 11 11:34:31 2013 +0100
> Committer: Dave Airlie <airlied@redhat.com>
> CommitDate: Wed Dec 18 11:08:36 2013 +1000
>
> drm: restrict the device list for shadow attached drivers
> @@ -465,8 +470,11 @@ void drm_pci_exit(struct drm_driver *driver, struct pci_driver *pdriver)
> if (driver->driver_features & DRIVER_MODESET) {
> pci_unregister_driver(pdriver);
> } else {
> - list_for_each_entry_safe(dev, tmp, &driver->device_list, driver_item)
> + list_for_each_entry_safe(dev, tmp, &driver->legacy_dev_list,
> + legacy_dev_list) {
> drm_put_dev(dev);
> + list_del(&dev->legacy_dev_list);
> + }
> }
Use-after-free. drm_put_dev frees dev.
Dave
parent reply other threads:[~2014-01-30 16:42 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <20140130045754.7E5C1660D2B@gitolite.kernel.org>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140130164151.GA24574@redhat.com \
--to=davej@redhat.com \
--cc=airlied@redhat.com \
--cc=daniel.vetter@ffwll.ch \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox