* Re: drm: restrict the device list for shadow attached drivers
[not found] <20140130045754.7E5C1660D2B@gitolite.kernel.org>
@ 2014-01-30 16:41 ` Dave Jones
0 siblings, 0 replies; only message in thread
From: Dave Jones @ 2014-01-30 16:41 UTC (permalink / raw)
To: Linux Kernel Mailing List; +Cc: daniel.vetter, airlied
On Thu, Jan 30, 2014 at 04:57:54AM +0000, Linux Kernel wrote:
> Gitweb: http://git.kernel.org/linus/;a=commit;h=b3f2333de8e81b089262b26d52272911523e605f
> Commit: b3f2333de8e81b089262b26d52272911523e605f
> Parent: e2577d455adb165e1046816e5ed092cc6d60f35a
> Author: Daniel Vetter <daniel.vetter@ffwll.ch>
> AuthorDate: Wed Dec 11 11:34:31 2013 +0100
> Committer: Dave Airlie <airlied@redhat.com>
> CommitDate: Wed Dec 18 11:08:36 2013 +1000
>
> drm: restrict the device list for shadow attached drivers
> @@ -465,8 +470,11 @@ void drm_pci_exit(struct drm_driver *driver, struct pci_driver *pdriver)
> if (driver->driver_features & DRIVER_MODESET) {
> pci_unregister_driver(pdriver);
> } else {
> - list_for_each_entry_safe(dev, tmp, &driver->device_list, driver_item)
> + list_for_each_entry_safe(dev, tmp, &driver->legacy_dev_list,
> + legacy_dev_list) {
> drm_put_dev(dev);
> + list_del(&dev->legacy_dev_list);
> + }
> }
Use-after-free. drm_put_dev frees dev.
Dave
^ permalink raw reply [flat|nested] only message in thread