From: Arnd Bergmann <arnd@arndb.de>
To: Pratyush Anand <pratyush.anand@st.com>
Cc: Kishon Vijay Abraham I <kishon@ti.com>,
Mohit KUMAR DCG <Mohit.KUMAR@st.com>,
"spear-devel" <spear-devel@list.st.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Bjorn Helgaas <bhelgaas@google.com>
Subject: Re: [PATCH V3 4/8] phy: Initialize phy core with subsys_initcall
Date: Fri, 31 Jan 2014 16:25:53 +0100 [thread overview]
Message-ID: <201401311625.53846.arnd@arndb.de> (raw)
In-Reply-To: <20140131034803.GA2618@pratyush-vbox>
On Friday 31 January 2014, Pratyush Anand wrote:
> > Having the PHY driver get initialized after the PCI root driver should
> > also work, but it requires correct handling of -EPROBE_DEFER: if phy_get
>
> I had issue with phy-core driver getting initialized after pcie rc
> driver. I found a kernel crash, as devm_phy_get was called before
> phy_class was created. I think this too need to be fixed, we should
> not see a crash.
Yes, agreed. This should be trivial to do though.
> Anyway, I will keep spear phy and rc driver both with module_init and
> -EPROBE_DEFER implementation.
Ok.
Arnd
prev parent reply other threads:[~2014-01-31 15:26 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1391077731.git.mohit.kumar@st.com>
2014-01-30 10:48 ` [PATCH V3 4/8] phy: Initialize phy core with subsys_initcall Mohit Kumar
2014-01-30 11:43 ` Kishon Vijay Abraham I
2014-01-30 11:52 ` Pratyush Anand
2014-01-30 12:10 ` Kishon Vijay Abraham I
2014-01-30 12:15 ` Pratyush Anand
2014-01-30 12:25 ` Kishon Vijay Abraham I
2014-01-30 12:44 ` Arnd Bergmann
2014-01-31 3:48 ` Pratyush Anand
2014-01-31 15:25 ` Arnd Bergmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201401311625.53846.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=Mohit.KUMAR@st.com \
--cc=bhelgaas@google.com \
--cc=kishon@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=pratyush.anand@st.com \
--cc=spear-devel@list.st.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).