Re: [PATCH] edac/85xx: Remove deprecated IRQF_DISABLED

Re: [PATCH] edac/85xx: Remove deprecated IRQF_DISABLED

[Johannes Thumshirn]

On Tue, Jan 21, 2014 at 09:42:27AM +0100, Johannes Thumshirn wrote:
> Remove IRQF_DISABLED as it is a NOOP.
>
> Signed-off-by: Johannes Thumshirn <johannes.thumshirn@men.de>
> ---
>  drivers/edac/mpc85xx_edac.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/edac/mpc85xx_edac.c b/drivers/edac/mpc85xx_edac.c
> index 8f918217..f4aec2e 100644
> --- a/drivers/edac/mpc85xx_edac.c
> +++ b/drivers/edac/mpc85xx_edac.c
> @@ -357,7 +357,7 @@ int mpc85xx_pci_err_probe(struct platform_device *op)
>  		pdata->irq = irq_of_parse_and_map(op->dev.of_node, 0);
>  		res = devm_request_irq(&op->dev, pdata->irq,
>  				       mpc85xx_pci_isr,
> -				       IRQF_DISABLED | IRQF_SHARED,
> +				       IRQF_SHARED,
>  				       "[EDAC] PCI err", pci);
>  		if (res < 0) {
>  			printk(KERN_ERR
> @@ -633,7 +633,7 @@ static int mpc85xx_l2_err_probe(struct platform_device *op)
>  	if (edac_op_state == EDAC_OPSTATE_INT) {
>  		pdata->irq = irq_of_parse_and_map(op->dev.of_node, 0);
>  		res = devm_request_irq(&op->dev, pdata->irq,
> -				       mpc85xx_l2_isr, IRQF_DISABLED,
> +				       mpc85xx_l2_isr, 0,
>  				       "[EDAC] L2 err", edac_dev);
>  		if (res < 0) {
>  			printk(KERN_ERR
> @@ -1133,7 +1133,7 @@ static int mpc85xx_mc_err_probe(struct platform_device *op)
>  		pdata->irq = irq_of_parse_and_map(op->dev.of_node, 0);
>  		res = devm_request_irq(&op->dev, pdata->irq,
>  				       mpc85xx_mc_isr,
> -					IRQF_DISABLED | IRQF_SHARED,
> +				       IRQF_SHARED,
>  				       "[EDAC] MC err", mci);
>  		if (res < 0) {
>  			printk(KERN_ERR "%s: Unable to request irq %d for "
> --
> 1.8.5.2
>

Boris, Mauro:

Ping?

Johannes

Re: [PATCH] edac/85xx: Remove deprecated IRQF_DISABLED

[Borislav Petkov]

On Mon, Feb 03, 2014 at 08:04:06AM +0100, Johannes Thumshirn wrote:
> Boris, Mauro:
> 
> Ping?

No worries, I saw your patch. But in the future, please hold off from
sending any patches during the merge window unless it is a serious
regression to code already upstream.

Thanks.

-- 
Regards/Gruss,
    Boris.

Sent from a fat crate under my desk. Formatting is fine.
--

Re: [PATCH] edac/85xx: Remove deprecated IRQF_DISABLED

[Johannes Thumshirn]

On Mon, Feb 03, 2014 at 10:34:58AM +0100, Borislav Petkov wrote:
> On Mon, Feb 03, 2014 at 08:04:06AM +0100, Johannes Thumshirn wrote:
> > Boris, Mauro:
> >
> > Ping?
>
> No worries, I saw your patch. But in the future, please hold off from
> sending any patches during the merge window unless it is a serious
> regression to code already upstream.
>
> Thanks.
>
> --
> Regards/Gruss,
>     Boris.
>
> Sent from a fat crate under my desk. Formatting is fine.
> --
> --
> To unsubscribe from this list: send the line "unsubscribe linux-edac" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

OK, sorry