From: Vivek Goyal <vgoyal@redhat.com>
To: "Pearson, Greg" <greg.pearson@hp.com>
Cc: "Eric W. Biederman" <ebiederm@xmission.com>,
Andrew Morton <akpm@linux-foundation.org>,
"d.hatayama@jp.fujitsu.com" <d.hatayama@jp.fujitsu.com>,
"holzheu@linux.vnet.ibm.com" <holzheu@linux.vnet.ibm.com>,
"dhowells@redhat.com" <dhowells@redhat.com>,
"paul.gortmaker@windriver.com" <paul.gortmaker@windriver.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] vmcore: prevent PT_NOTE p_memsz overflow during header update
Date: Mon, 3 Feb 2014 12:05:26 -0500 [thread overview]
Message-ID: <20140203170526.GB10795@redhat.com> (raw)
In-Reply-To: <52EFCA92.3030903@hp.com>
On Mon, Feb 03, 2014 at 04:57:56PM +0000, Pearson, Greg wrote:
[..]
> > So I will not be too worried about skipping seemingly corrupted ELf
> > notes. I think giving a warning makes sense though. Is somebody
> > overwriting the memory area in kenrel reserved for per cpu PT_NOTE.
>
> I haven't figured out the cause of the strange second PT_NOTE entries
> yet, but I suspect some type of memory corruption.
Hi Greg,
May be put some printk() in crash_save_cpu() and make sure that at
creation time notes are being created properly. That will atleast
make clear whether elf notes were not created properly or they got
corrupted later.
Thanks
Vivek
prev parent reply other threads:[~2014-02-03 17:05 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-31 23:06 [PATCH] vmcore: prevent PT_NOTE p_memsz overflow during header update Greg Pearson
2014-01-31 23:14 ` Andrew Morton
2014-01-31 23:16 ` Andrew Morton
2014-02-01 1:07 ` Pearson, Greg
2014-02-01 2:12 ` Andrew Morton
2014-02-02 22:25 ` Eric W. Biederman
2014-02-03 15:47 ` Vivek Goyal
2014-02-03 16:57 ` Pearson, Greg
2014-02-03 17:05 ` Vivek Goyal [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140203170526.GB10795@redhat.com \
--to=vgoyal@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=d.hatayama@jp.fujitsu.com \
--cc=dhowells@redhat.com \
--cc=ebiederm@xmission.com \
--cc=greg.pearson@hp.com \
--cc=holzheu@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=paul.gortmaker@windriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox