From: Andrew Morton <akpm@linux-foundation.org>
To: Sebastian Capella <sebastian.capella@linaro.org>
Cc: David Rientjes <rientjes@google.com>,
"Alexey Dobriyan" <adobriyan@gmail.com>,
"Linux Kernel" <linux-kernel@vger.kernel.org>,
mm-commits@vger.kernel.org, "Joe Perches" <joe@perches.com>
Subject: Re: + mm-utilc-add-kstrimdup.patch added to -mm tree
Date: Mon, 3 Feb 2014 18:42:45 -0800 [thread overview]
Message-ID: <20140203184245.33ac93bf.akpm@linux-foundation.org> (raw)
In-Reply-To: <20140204012816.22878.4159@capellas-linux>
On Mon, 03 Feb 2014 17:28:16 -0800 Sebastian Capella <sebastian.capella@linaro.org> wrote:
> Quoting David Rientjes (2014-02-03 17:05:04)
> > The last we heard, I think Sebastian is looking to redo this series and
> > this patch is no longer needed. Sebastian?
> Hi David, Alexey,
>
> I am in the process of reworking the patches. I'm not sure if Andrew
> was just interested in having the kstrimdup utility function available.
>
> Isn't it too late to impose userspace trimming of newlines for sysfs?
> It seems already fairly common and expected for the kernel to eat the
> trailing whitespace, or at least ignore it. If we change this won't we
> be breaking userspace / tools / instructions / etc?
>
We have quite a lot of codesites which open-code the newline trimming.
Providing a library function to do this will result in goodness.
That being said, I don't plan to merge kstrimdup() until it has some users.
prev parent reply other threads:[~2014-02-04 2:38 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <52ec195e.P8S/D298ZeaBLTvn%akpm@linux-foundation.org>
2014-02-03 9:58 ` + mm-utilc-add-kstrimdup.patch added to -mm tree Alexey Dobriyan
2014-02-04 1:05 ` David Rientjes
2014-02-04 1:28 ` Sebastian Capella
2014-02-04 1:32 ` David Rientjes
2014-02-04 2:42 ` Andrew Morton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140203184245.33ac93bf.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=adobriyan@gmail.com \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mm-commits@vger.kernel.org \
--cc=rientjes@google.com \
--cc=sebastian.capella@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox