linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Borislav Petkov <bp@alien8.de>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
	David Rientjes <rientjes@google.com>,
	LKML <linux-kernel@vger.kernel.org>, X86 ML <x86@kernel.org>,
	Richard Weinberger <richard@nod.at>, Borislav Petkov <bp@suse.de>
Subject: Re: [PATCH] Clarify CONFIG_DEBUG_INFO's bloaty nature
Date: Tue, 4 Feb 2014 05:59:04 +0100	[thread overview]
Message-ID: <20140204045904.GA4340@pd.tnic> (raw)
In-Reply-To: <20140203145718.5bc9ba1619aff8ea0754b0ab@linux-foundation.org>

On Mon, Feb 03, 2014 at 02:57:18PM -0800, Andrew Morton wrote:
> On Mon, 3 Feb 2014 14:47:15 -0800 Linus Torvalds <torvalds@linux-foundation.org> wrote:
> 
> > On Mon, Feb 3, 2014 at 2:00 PM, David Rientjes <rientjes@google.com> wrote:
> > >
> > > How do you define "huge bloat" if the size of vmlinux doesn't increase?
> > 
> > Don't be silly. The size of all the object files increase *hugely*.
> 
> yup, I disable this in my allmodconfig testing, to great effect.
> 
> That being said, I do think the text should make clear that the bloat
> is a compile-time impact and not a runtime one.  Something like
> 
> --- a/lib/Kconfig.debug~lib-kconfigdebug-clarify-config_debug_infos-bloaty-nature-fix
> +++ a/lib/Kconfig.debug
> @@ -128,9 +128,9 @@ config DEBUG_INFO
>  	  tools like crash, kgdb, LKCD, gdb, etc on the kernel.
>  
>  	  If you only want to have resolved symbols in kernel traces and
> -	  are not going to need support for those tools above, you don't need
> -	  to enable this as it is a huge bloat and build slowdown;
> -	  enable CONFIG_KALLSYMS instead.
> +	  are not going to need support for the above tools, you don't need
> +	  to enable this.  It hugely bloat object files' on-disk sizes and slows
> +	  the build.  Enable CONFIG_KALLSYMS instead.

Yes, this is better.

Andrew, can you add that or you want me to send a new version?

Thanks.

-- 
Regards/Gruss,
    Boris.

Sent from a fat crate under my desk. Formatting is fine.
--

      parent reply	other threads:[~2014-02-04  4:59 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-03 18:29 [PATCH] Clarify CONFIG_DEBUG_INFO's bloaty nature Borislav Petkov
2014-02-03 22:00 ` David Rientjes
2014-02-03 22:47   ` Linus Torvalds
2014-02-03 22:57     ` Andrew Morton
2014-02-03 23:34       ` David Rientjes
2014-02-04  9:08         ` Ingo Molnar
2014-02-04 16:36           ` Linus Torvalds
2014-02-04 17:32             ` Andi Kleen
2014-02-04 18:41               ` Linus Torvalds
2014-02-05  5:51                 ` [PATCH] x86: Disable CONFIG_X86_DECODER_SELFTEST in allmod/allyesconfigs Ingo Molnar
2014-02-05 16:17                   ` Paul Gortmaker
2014-02-05 17:32                     ` Andi Kleen
2014-02-10 13:31                   ` [tip:x86/urgent] x86/debug: " tip-bot for Ingo Molnar
2014-02-11  0:01                   ` [PATCH] x86: " Stephen Rothwell
2014-02-11  7:14                     ` Ingo Molnar
2014-02-05  5:46             ` [PATCH] Clarify CONFIG_DEBUG_INFO's bloaty nature Ingo Molnar
2014-02-04  4:59       ` Borislav Petkov [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140204045904.GA4340@pd.tnic \
    --to=bp@alien8.de \
    --cc=akpm@linux-foundation.org \
    --cc=bp@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=richard@nod.at \
    --cc=rientjes@google.com \
    --cc=torvalds@linux-foundation.org \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).