public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Hannes Reinecke <hare@suse.de>
Cc: systemd-devel@lists.freedesktop.org, Kay Sievers <kay@vrfy.org>,
	linux-kernel@vger.kernel.org
Subject: Re: [systemd-devel] [PATCH] tty: Set correct tty name in 'active' sysfs attribute
Date: Wed, 5 Feb 2014 17:38:16 +0100	[thread overview]
Message-ID: <20140205163816.GC12783@kroah.com> (raw)
In-Reply-To: <1391595106-86957-1-git-send-email-hare@suse.de>

On Wed, Feb 05, 2014 at 11:11:46AM +0100, Hannes Reinecke wrote:
> The 'active' sysfs attribute should refer to the currently
> active tty devices the console is running on, not the currently
> active console.
> The console structure doesn't refer to any device in sysfs,
> only the tty the console is running on has.
> So we need to print out the tty names in 'active', not
> the console names.
> 
> Cc: Lennart Poettering <lennart@poettering.net>
> Cc: Kay Sievers <kay@vrfy.org>
> Signed-off-by: Werner Fink <werner@suse.de>
> Signed-off-by: Hannes Reinecke <hare@suse.de>
> ---
>  drivers/tty/tty_io.c | 14 ++++++++++++--
>  1 file changed, 12 insertions(+), 2 deletions(-)

Would have been nice to actually cc: the tty maintainer(s) :(

scripts/get_maintainer.pl is your friend...

greg k-h

      parent reply	other threads:[~2014-02-05 16:36 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-05 10:11 [PATCH] tty: Set correct tty name in 'active' sysfs attribute Hannes Reinecke
2014-02-05 12:53 ` [systemd-devel] " David Herrmann
2014-02-05 13:53   ` Peter Hurley
2014-02-05 14:05     ` David Herrmann
2014-02-05 14:19       ` Peter Hurley
2014-02-06 15:46   ` Hannes Reinecke
2014-02-05 16:38 ` Greg KH [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140205163816.GC12783@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=hare@suse.de \
    --cc=kay@vrfy.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=systemd-devel@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox