From: Arnd Bergmann <arnd@arndb.de>
To: Jingoo Han <jg1.han@samsung.com>
Cc: "'Linus Walleij'" <linus.walleij@linaro.org>,
"'Thierry Reding'" <thierry.reding@gmail.com>,
"'Russell King - ARM Linux'" <linux@arm.linux.org.uk>,
"'Eric Miao'" <eric.y.miao@gmail.com>,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, linux-pwm@vger.kernel.org
Subject: Re: [PATCH] backlight: add PWM dependencies
Date: Thu, 6 Feb 2014 17:08:05 +0100 [thread overview]
Message-ID: <201402061708.05845.arnd@arndb.de> (raw)
In-Reply-To: <000001cf230c$60ec1ca0$22c455e0$%han@samsung.com>
On Thursday 06 February 2014, Jingoo Han wrote:
> In the case of "CONFIG_HAVE_PWM=y && CONFIG_PWM=n", it makes
> the problem.
>
> The HAVE_PWM symbol is only for legacy platforms that provide
> the PWM API without using the generic framework. PXA looks to
> use the generic PWM framework. Then, how about removing
> "select HAVE_PWM" from PXA as below?
>
I think this is correct, but we may need additional patches. I notice
that INPUT_MAX8997_HAPTIC and INPUT_PWM_BEEPER have a dependency on
HAVE_PWM at the moment, so those two drivers become impossible
to select after your change.
There is also one use of HAVE_PWM outside of PXA, for ARCH_LPC32XX.
This one seems to have the same problem.
Finally, I have recently encountered a couple of drivers
(BACKLIGHT_LM3630A, BACKLIGHT_LP855X, BACKLIGHT_LP8788) that use
the PWM interfaces but are missing a 'depends on PWM'. This is
strictly speaking a different problem, but we could try to solve
it at the same time.
Arnd
next prev parent reply other threads:[~2014-02-06 16:08 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-04 12:57 [PATCH] backlight: add PWM dependencies Linus Walleij
2014-02-05 5:01 ` Jingoo Han
2014-02-05 8:57 ` Linus Walleij
2014-02-06 6:49 ` Jingoo Han
2014-02-06 7:23 ` Jingoo Han
2014-02-06 8:32 ` Linus Walleij
2014-02-06 16:08 ` Arnd Bergmann [this message]
2014-02-06 16:35 ` Arnd Bergmann
2014-02-07 3:05 ` Jingoo Han
2014-02-07 9:40 ` Arnd Bergmann
2014-02-10 10:40 ` Thierry Reding
2014-02-10 11:09 ` Linus Walleij
2014-02-26 13:25 ` Thierry Reding
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201402061708.05845.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=eric.y.miao@gmail.com \
--cc=jg1.han@samsung.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox