From: Rodrigo Campos <rodrigo@sdfg.com.ar>
To: Namhyung Kim <namhyung@kernel.org>
Cc: Arnaldo Carvalho de Melo <acme@ghostprotocols.net>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Ingo Molnar <mingo@kernel.org>, Paul Mackerras <paulus@samba.org>,
Namhyung Kim <namhyung.kim@lge.com>,
LKML <linux-kernel@vger.kernel.org>, Arun Sharma <asharma@fb.com>,
Frederic Weisbecker <fweisbec@gmail.com>,
Andi Kleen <andi@firstfloor.org>, David Ahern <dsahern@gmail.com>
Subject: Re: [PATCHSET 00/21] perf tools: Add support to accumulate hist periods (v8)
Date: Fri, 7 Feb 2014 03:31:10 +0000 [thread overview]
Message-ID: <20140207033110.GA17630@sdfg.com.ar> (raw)
In-Reply-To: <1391736923-30765-1-git-send-email-namhyung@kernel.org>
On Fri, Feb 07, 2014 at 10:35:02AM +0900, Namhyung Kim wrote:
>
> Currently the perf enables both of --call-graph and --children when it
> finds callchains in the samples. While this is useful for TUI or GTK,
> I'm not sure for stdio as it'd consume so much lines.
>
> It does not handle all kind of cases like event groups and annotations
> yet, but I really want to release it and get reviews.
>
> You can also get this series on 'perf/cumulate-v8' branch in my tree at:
>
> git://git.kernel.org/pub/scm/linux/kernel/git/namhyung/linux-perf.git
I've modified a little your example to link against two libraries dynamically
and see different cases of how is self vs children attributed when running with
"--sort dso" and it seems great.
I've tried simple examples just as: calling a lib1 function that calls lib2
function which uses lot of CPU, calling lib1 function that uses lot of CPU and
also calls lib2 func that uses lot of CPU. And things like that. Probably using
one lib was enough (I first played with only one) as it's a different symbol
from the main, but just in case some weird bug (was really easy) I tested with
two :-)
I might be able to test with more real world scenarios on Saturday, although I'm
sick now and I'm not sure how I will feel :S
Thanks a lot!
Rodrigo
next prev parent reply other threads:[~2014-02-07 4:04 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-07 1:35 [PATCHSET 00/21] perf tools: Add support to accumulate hist periods (v8) Namhyung Kim
2014-02-07 1:35 ` [PATCH 01/21] perf tools: Introduce struct hist_entry_iter Namhyung Kim
2014-02-07 1:35 ` [PATCH 02/21] perf hists: Add support for accumulated stat of hist entry Namhyung Kim
2014-02-07 1:35 ` [PATCH 03/21] perf hists: Check if accumulated when adding a " Namhyung Kim
2014-02-07 1:35 ` [PATCH 04/21] perf hists: Accumulate hist entry stat based on the callchain Namhyung Kim
2014-02-07 1:35 ` [PATCH 05/21] perf tools: Update cpumode for each cumulative entry Namhyung Kim
2014-02-07 1:35 ` [PATCH 06/21] perf report: Cache cumulative callchains Namhyung Kim
2014-02-07 1:35 ` [PATCH 07/21] perf callchain: Add callchain_cursor_snapshot() Namhyung Kim
2014-02-07 1:35 ` [PATCH 08/21] perf tools: Save callchain info for each cumulative entry Namhyung Kim
2014-02-07 1:35 ` [PATCH 09/21] perf hists: Sort hist entries by accumulated period Namhyung Kim
2014-02-07 1:35 ` [PATCH 10/21] perf ui/hist: Add support to accumulated hist stat Namhyung Kim
2014-02-07 1:35 ` [PATCH 11/21] perf ui/browser: " Namhyung Kim
2014-02-07 1:35 ` [PATCH 12/21] perf ui/gtk: " Namhyung Kim
2014-02-07 1:35 ` [PATCH 13/21] perf tools: Apply percent-limit to cumulative percentage Namhyung Kim
2014-02-07 1:35 ` [PATCH 14/21] perf tools: Add more hpp helper functions Namhyung Kim
2014-02-07 1:35 ` [PATCH 15/21] perf report: Add --children option Namhyung Kim
2014-02-07 1:35 ` [PATCH 16/21] perf report: Add report.children config option Namhyung Kim
2014-02-07 1:35 ` [PATCH 17/21] perf tools: Add callback function to hist_entry_iter Namhyung Kim
2014-02-07 1:35 ` [PATCH 18/21] perf top: Convert " Namhyung Kim
2014-02-07 13:26 ` Rodrigo Campos
2014-02-10 2:58 ` Namhyung Kim
2014-02-07 1:35 ` [PATCH 19/21] perf top: Add --children option Namhyung Kim
2014-02-07 1:35 ` [PATCH 20/21] perf top: Add top.children config option Namhyung Kim
2014-02-07 1:35 ` [PATCH 21/21] perf tools: Enable --children option by default Namhyung Kim
2014-02-07 3:31 ` Rodrigo Campos [this message]
2014-02-10 2:43 ` [PATCHSET 00/21] perf tools: Add support to accumulate hist periods (v8) Namhyung Kim
2014-02-10 8:07 ` Jiri Olsa
2014-02-10 11:00 ` Namhyung Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140207033110.GA17630@sdfg.com.ar \
--to=rodrigo@sdfg.com.ar \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@ghostprotocols.net \
--cc=andi@firstfloor.org \
--cc=asharma@fb.com \
--cc=dsahern@gmail.com \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=namhyung.kim@lge.com \
--cc=namhyung@kernel.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox