From: Mark Brown <broonie@kernel.org>
To: Lee Jones <lee.jones@linaro.org>
Cc: Adam Thomson <Adam.Thomson.Opensource@diasemi.com>,
alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
Linus Walleij <linus.walleij@linaro.org>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Alessandro Zummo <a.zummo@towertech.it>,
Guenter Roeck <linux@roeck-us.net>
Subject: Re: [PATCH v2 1/8] ASoC: da9055: Fix device registration of PMIC and CODEC devices
Date: Fri, 7 Feb 2014 12:58:31 +0000 [thread overview]
Message-ID: <20140207125831.GL32298@sirena.org.uk> (raw)
In-Reply-To: <20140207105657.GL14727@lee--X1>
[-- Attachment #1: Type: text/plain, Size: 912 bytes --]
On Fri, Feb 07, 2014 at 10:56:57AM +0000, Lee Jones wrote:
> > +/*
> > + * DO NOT change the device Ids. The naming is intentionally specific as both
> > + * the PMIC and CODEC parts of this chip are instantiated separately as I2C
> > + * devices (both have configurable I2C addresses, and are to all intents and
> > + * purposes separate). As a result there are specific DA9055 ids for PMIC
> > + * and CODEC, which must be different to operate together.
> > + */
> I'm not sure this comment is required.
They are, we've already had the suffixes removed from both PMIC and
CODEC drivers by people doing code review causing the drivers to fail to
load for several kernel releases (this should be tagged to stable as a
result).
> Most device IDs are named this way.
Having the suffix on a subdevice would be normal but it's not normal for
the primary I2C device, usually you can just put the part number in.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2014-02-07 12:58 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-06 18:03 [PATCH v2 0/8] da9055: Driver initialisation fixes, add DT support Adam Thomson
2014-02-06 18:03 ` [PATCH v2 1/8] ASoC: da9055: Fix device registration of PMIC and CODEC devices Adam Thomson
2014-02-07 10:56 ` Lee Jones
2014-02-07 12:58 ` Mark Brown [this message]
2014-02-10 11:51 ` Lee Jones
2014-02-10 13:43 ` Mark Brown
2014-02-10 13:59 ` Lee Jones
2014-02-10 14:14 ` Mark Brown
2014-02-10 14:42 ` Lee Jones
2014-02-10 14:51 ` Mark Brown
2014-02-06 18:03 ` [PATCH v2 2/8] ASoC: da9055: Add DT support for CODEC Adam Thomson
2014-02-07 16:25 ` Mark Brown
2014-02-07 16:26 ` Mark Brown
2014-02-10 10:48 ` Opensource [Adam Thomson]
2014-02-06 18:03 ` [PATCH v2 3/8] mfd: da9055: Add DT support for PMIC Adam Thomson
2014-02-07 11:03 ` Lee Jones
2014-02-07 15:45 ` Opensource [Adam Thomson]
2014-02-06 18:03 ` [PATCH v2 4/8] regulator: da9055: Add DT support Adam Thomson
2014-02-07 16:31 ` Mark Brown
2014-02-06 18:03 ` [PATCH v2 5/8] onkey: da9055: Remove use of regmap_irq_get_virq() Adam Thomson
2014-02-06 18:03 ` [PATCH v2 6/8] hwmon: " Adam Thomson
2014-02-07 1:29 ` Guenter Roeck
2014-02-06 18:03 ` [PATCH v2 7/8] rtc: " Adam Thomson
2014-02-06 18:03 ` [PATCH v2 8/8] regulator: " Adam Thomson
2014-02-07 16:31 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140207125831.GL32298@sirena.org.uk \
--to=broonie@kernel.org \
--cc=Adam.Thomson.Opensource@diasemi.com \
--cc=a.zummo@towertech.it \
--cc=alsa-devel@alsa-project.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=lee.jones@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox