From: David Fries <david@fries.net>
To: zbr@ioremap.net
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 0/4] w1: refcnt fix, skip non-error send, docs
Date: Fri, 7 Feb 2014 16:23:45 -0600 [thread overview]
Message-ID: <20140207222345.GR5452@spacedout.fries.net> (raw)
In-Reply-To: <7611391808223@web21g.yandex.ru>
On Sat, Feb 08, 2014 at 01:23:43AM +0400, zbr@ioremap.net wrote:
> Hi
>
> 07.02.2014, 10:00, "David Fries" <david@fries.net>:
>
> > Here's a patch to implement that. Is this what you have in mind?
> >
> > From 4ed65d81b0121a8c191a9833d041484e9097198b Mon Sep 17 00:00:00 2001
> > From: David Fries <David@Fries.net>
> > Date: Thu, 6 Feb 2014 23:45:05 -0600
> > Subject: [PATCH] w1: correct cn_msg ack, no change or seq + 1
> >
> > Netlink messages sent from the kernel consists of kernel generated
> > notifications for adds or removes, the error message (also indicates
> > the message has been processed), and the messages that have data to
> > return. The cn_msg ack is left alone for the first two, and when
> > returning data it is the sequence number + 1. Modifying the code to
> > the protocol standard.
> >
> > Signed-off-by: David Fries <David@Fries.net>
>
> Yes, it looks right.
> Can you also check that protocol documentation is correct?
Documentation/connector/connector.txt ? I found it a little unclear,
I'll see what I can do.
--
David Fries <david@fries.net> PGP pub CB1EE8F0
http://fries.net/~david/
next prev parent reply other threads:[~2014-02-07 22:25 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-03 1:14 [PATCH 0/4] w1: refcnt fix, skip non-error send, docs David Fries
2014-02-03 1:15 ` [PATCH 1/4] w1: fix netlink refcnt leak on error path David Fries
2014-02-03 1:15 ` [PATCH 2/4] w1: only send_error when there is an error David Fries
2014-02-03 1:15 ` [PATCH 3/4] w1: document struct w1_netlink_msg and struct w1_netlink_cmd David Fries
2014-02-03 1:15 ` [PATCH 4/4] w1: update cn_netlink_send documentation David Fries
2014-02-03 23:59 ` [PATCH 0/4] w1: refcnt fix, skip non-error send, docs zbr
2014-02-04 5:51 ` David Fries
2014-02-04 23:48 ` zbr
2014-02-07 5:58 ` David Fries
2014-02-07 21:23 ` zbr
2014-02-07 22:23 ` David Fries [this message]
2014-02-07 22:35 ` zbr
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140207222345.GR5452@spacedout.fries.net \
--to=david@fries.net \
--cc=linux-kernel@vger.kernel.org \
--cc=zbr@ioremap.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox