From: Josh Triplett <josh@joshtriplett.org>
To: Rashika Kheria <rashika.kheria@gmail.com>
Cc: linux-kernel@vger.kernel.org, Jens Axboe <axboe@kernel.dk>
Subject: Re: [PATCH 1/2] block: Mark function as static in blk-lib.c
Date: Sat, 8 Feb 2014 10:37:42 -0800 [thread overview]
Message-ID: <20140208183742.GB14801@leaf> (raw)
In-Reply-To: <7dce86ade62eada14e58bb334bb9b7bd87627b68.1391876538.git.rashika.kheria@gmail.com>
On Sat, Feb 08, 2014 at 09:54:44PM +0530, Rashika Kheria wrote:
> Mark function as static in blk-lib.c because it is not used outside this
> file.
>
> This eliminates the following warning in blk-lib.c:
> block/blk-lib.c:221:5: warning: no previous prototype for ‘__blkdev_issue_zeroout’ [-Wmissing-prototypes]
>
> Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com>
Reviewed-by: Josh Triplett <josh@joshtriplett.org>
> block/blk-lib.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/block/blk-lib.c b/block/blk-lib.c
> index 2da76c9..332e7a9 100644
> --- a/block/blk-lib.c
> +++ b/block/blk-lib.c
> @@ -218,7 +218,7 @@ EXPORT_SYMBOL(blkdev_issue_write_same);
> * Generate and issue number of bios with zerofiled pages.
> */
>
> -int __blkdev_issue_zeroout(struct block_device *bdev, sector_t sector,
> +static int __blkdev_issue_zeroout(struct block_device *bdev, sector_t sector,
> sector_t nr_sects, gfp_t gfp_mask)
> {
> int ret;
> --
> 1.7.9.5
>
prev parent reply other threads:[~2014-02-08 18:37 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-08 16:24 [PATCH 1/2] block: Mark function as static in blk-lib.c Rashika Kheria
2014-02-08 16:26 ` [PATCH 2/2] block: Mark function as static in blk-throttle.c Rashika Kheria
2014-02-08 18:38 ` Josh Triplett
2014-02-08 18:37 ` Josh Triplett [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140208183742.GB14801@leaf \
--to=josh@joshtriplett.org \
--cc=axboe@kernel.dk \
--cc=linux-kernel@vger.kernel.org \
--cc=rashika.kheria@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox