public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Josh Triplett <josh@joshtriplett.org>
To: Rashika Kheria <rashika.kheria@gmail.com>
Cc: linux-kernel@vger.kernel.org, Jens Axboe <axboe@kernel.dk>
Subject: Re: [PATCH 2/2] block: Mark function as static in blk-throttle.c
Date: Sat, 8 Feb 2014 10:38:04 -0800	[thread overview]
Message-ID: <20140208183804.GC14801@leaf> (raw)
In-Reply-To: <44a81d7a082f5e30aaa7a2428421beddbc934293.1391876538.git.rashika.kheria@gmail.com>

On Sat, Feb 08, 2014 at 09:56:21PM +0530, Rashika Kheria wrote:
> Mark functions as static in blk-throttle.c because it is not used
> outside this file.
> 
> This eliminates the following warning in blk-throttle.c:
> block/blk-throttle.c:1261:6: warning: no previous prototype for ‘blk_throtl_dispatch_work_fn’ [-Wmissing-prototypes]
> 
> Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com>

Reviewed-by: Josh Triplett <josh@joshtriplett.org>

>  block/blk-throttle.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/block/blk-throttle.c b/block/blk-throttle.c
> index 1474c3a..0face33 100644
> --- a/block/blk-throttle.c
> +++ b/block/blk-throttle.c
> @@ -1258,7 +1258,7 @@ out_unlock:
>   * of throtl_data->service_queue.  Those bio's are ready and issued by this
>   * function.
>   */
> -void blk_throtl_dispatch_work_fn(struct work_struct *work)
> +static void blk_throtl_dispatch_work_fn(struct work_struct *work)
>  {
>  	struct throtl_data *td = container_of(work, struct throtl_data,
>  					      dispatch_work);
> -- 
> 1.7.9.5
> 

  reply	other threads:[~2014-02-08 18:38 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-08 16:24 [PATCH 1/2] block: Mark function as static in blk-lib.c Rashika Kheria
2014-02-08 16:26 ` [PATCH 2/2] block: Mark function as static in blk-throttle.c Rashika Kheria
2014-02-08 18:38   ` Josh Triplett [this message]
2014-02-08 18:37 ` [PATCH 1/2] block: Mark function as static in blk-lib.c Josh Triplett

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140208183804.GC14801@leaf \
    --to=josh@joshtriplett.org \
    --cc=axboe@kernel.dk \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rashika.kheria@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox