Re: [PATCH 02/21] fs: Include appropriate header file in dlm/ast.c

[Josh Triplett <josh@joshtriplett.org>]

On Sun, Feb 09, 2014 at 06:19:17PM +0530, Rashika Kheria wrote:
> Include appropriate header file fs/dlm/ast.h in fs/dlm/ast.c because it
> contains function prototypes of some functions defined in fs/dlm/ast.c.
> 
> This also eliminates the following warning in fs/dlm/ast:
> fs/dlm/ast.c:52:5: warning: no previous prototype for ‘dlm_add_lkb_callback’ [-Wmissing-prototypes]
> fs/dlm/ast.c:113:5: warning: no previous prototype for ‘dlm_rem_lkb_callback’ [-Wmissing-prototypes]
> fs/dlm/ast.c:174:6: warning: no previous prototype for ‘dlm_add_cb’ [-Wmissing-prototypes]
> fs/dlm/ast.c:212:6: warning: no previous prototype for ‘dlm_callback_work’ [-Wmissing-prototypes]
> fs/dlm/ast.c:267:5: warning: no previous prototype for ‘dlm_callback_start’ [-Wmissing-prototypes]
> fs/dlm/ast.c:278:6: warning: no previous prototype for ‘dlm_callback_stop’ [-Wmissing-prototypes]
> fs/dlm/ast.c:284:6: warning: no previous prototype for ‘dlm_callback_suspend’ [-Wmissing-prototypes]
> fs/dlm/ast.c:292:6: warning: no previous prototype for ‘dlm_callback_resume’ [-Wmissing-prototypes]
> 
> Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com>

Reviewed-by: Josh Triplett <josh@joshtriplett.org>

>  fs/dlm/ast.c |    1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/fs/dlm/ast.c b/fs/dlm/ast.c
> index 0e90f0c..42794c0 100644
> --- a/fs/dlm/ast.c
> +++ b/fs/dlm/ast.c
> @@ -14,6 +14,7 @@
>  #include "dlm_internal.h"
>  #include "lock.h"
>  #include "user.h"
> +#include "ast.h"
>  
>  static uint64_t dlm_cb_seq;
>  static DEFINE_SPINLOCK(dlm_cb_seq_spin);
> -- 
> 1.7.9.5
>