From: Nicolin Chen <Guangyu.Chen@freescale.com>
To: Xiubo Li <Li.Xiubo@freescale.com>
Cc: <broonie@kernel.org>, <lgirdwood@gmail.com>, <perex@perex.cz>,
<tiwai@suse.de>, <alsa-devel@alsa-project.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ASoC: fsl-esai: fix ESAI TDM slot setting
Date: Mon, 10 Feb 2014 15:50:32 +0800 [thread overview]
Message-ID: <20140210075031.GA16453@MrMyself> (raw)
In-Reply-To: <1392014837-22308-1-git-send-email-Li.Xiubo@freescale.com>
On Mon, Feb 10, 2014 at 02:47:17PM +0800, Xiubo Li wrote:
> Cc: Nicolin Chen <Guangyu.Chen@freescale.com>
> Signed-off-by: Xiubo Li <Li.Xiubo@freescale.com>
> ---
> sound/soc/fsl/fsl_esai.c | 4 ++--
> sound/soc/fsl/fsl_esai.h | 2 +-
> 2 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/sound/soc/fsl/fsl_esai.c b/sound/soc/fsl/fsl_esai.c
> index d0c72ed..c84026c 100644
> --- a/sound/soc/fsl/fsl_esai.c
> +++ b/sound/soc/fsl/fsl_esai.c
> @@ -326,7 +326,7 @@ static int fsl_esai_set_dai_tdm_slot(struct snd_soc_dai *dai, u32 tx_mask,
> regmap_update_bits(esai_priv->regmap, REG_ESAI_TSMA,
> ESAI_xSMA_xS_MASK, ESAI_xSMA_xS(tx_mask));
> regmap_update_bits(esai_priv->regmap, REG_ESAI_TSMB,
> - ESAI_xSMA_xS_MASK, ESAI_xSMB_xS(tx_mask));
> + ESAI_xSMB_xS_MASK, ESAI_xSMB_xS(tx_mask));
>
> regmap_update_bits(esai_priv->regmap, REG_ESAI_RCCR,
> ESAI_xCCR_xDC_MASK, ESAI_xCCR_xDC(slots));
> @@ -334,7 +334,7 @@ static int fsl_esai_set_dai_tdm_slot(struct snd_soc_dai *dai, u32 tx_mask,
> regmap_update_bits(esai_priv->regmap, REG_ESAI_RSMA,
> ESAI_xSMA_xS_MASK, ESAI_xSMA_xS(rx_mask));
> regmap_update_bits(esai_priv->regmap, REG_ESAI_RSMB,
> - ESAI_xSMA_xS_MASK, ESAI_xSMB_xS(rx_mask));
> + ESAI_xSMB_xS_MASK, ESAI_xSMB_xS(rx_mask));
>
> esai_priv->slot_width = slot_width;
>
> diff --git a/sound/soc/fsl/fsl_esai.h b/sound/soc/fsl/fsl_esai.h
> index 9c9f957..75e1403 100644
> --- a/sound/soc/fsl/fsl_esai.h
> +++ b/sound/soc/fsl/fsl_esai.h
> @@ -322,7 +322,7 @@
> #define ESAI_xSMB_xS_SHIFT 0
> #define ESAI_xSMB_xS_WIDTH 16
> #define ESAI_xSMB_xS_MASK (((1 << ESAI_xSMB_xS_WIDTH) - 1) << ESAI_xSMB_xS_SHIFT)
> -#define ESAI_xSMB_xS(v) (((v) >> ESAI_xSMA_xS_WIDTH) & ESAI_xSMA_xS_MASK)
> +#define ESAI_xSMB_xS(v) (((v) >> ESAI_xSMA_xS_WIDTH) & ESAI_xSMB_xS_MASK)
It should use ESAI_xSMB_xS_WIDTH.
Otherwise, it looks fine. Thank you.
Acked-by: Nicolin Chen <Guangyu.Chen@freescale.com>
---
>
> /* Port C Direction Register -- REG_ESAI_PRRC 0xF8 */
> #define ESAI_PRRC_PDC_SHIFT 0
> --
> 1.8.4
>
>
next prev parent reply other threads:[~2014-02-10 8:06 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-10 6:47 [PATCH] ASoC: fsl-esai: fix ESAI TDM slot setting Xiubo Li
2014-02-10 7:50 ` Nicolin Chen [this message]
2014-02-10 8:18 ` Li.Xiubo
2014-02-10 8:24 ` Li.Xiubo
2014-02-10 8:15 ` Nicolin Chen
2014-02-10 13:40 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140210075031.GA16453@MrMyself \
--to=guangyu.chen@freescale.com \
--cc=Li.Xiubo@freescale.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox