Re: [PATCH] staging : android : fix checkpatch issues

Dan Carpenter
2014-02-10T09:11:35Z

On Mon, Feb 10, 2014 at 10:59:14AM +0900, Daeseok Youn wrote:
> @@ -1376,14 +1376,14 @@ static int ion_debug_heap_show(struct seq_file *s, void *unused)
> }
> }
> mutex_unlock(&dev->buffer_lock);
> - seq_printf(s, "----------------------------------------------------\n");
> + seq_puts(s, "----------------------------------------------------\n");
> seq_printf(s, "%16.s %16zu\n", "total orphaned",
> total_orphaned_size);

This kind of thing where you put a seq_puts() in the middle of a string
of seq_printf() calls is not good. We only make checkpatch.pl warn
about it to see if patch submitters are paying attention and to test the
patience of reviewers.

regards,
dan carpenter