Re: [PATCH v2 1/8] ASoC: da9055: Fix device registration of PMIC and CODEC devices

Mark Brown
2014-02-07T12:58:48Z

[-- Attachment #1: Type: text/plain, Size: 912 bytes --]

On Fri, Feb 07, 2014 at 10:56:57AM +0000, Lee Jones wrote:

> > +/*
> > + * DO NOT change the device Ids. The naming is intentionally specific as both
> > + * the PMIC and CODEC parts of this chip are instantiated separately as I2C
> > + * devices (both have configurable I2C addresses, and are to all intents and
> > + * purposes separate). As a result there are specific DA9055 ids for PMIC
> > + * and CODEC, which must be different to operate together.
> > + */

> I'm not sure this comment is required.

They are, we've already had the suffixes removed from both PMIC and
CODEC drivers by people doing code review causing the drivers to fail to
load for several kernel releases (this should be tagged to stable as a
result).

> Most device IDs are named this way.

Having the suffix on a subdevice would be normal but it's not normal for
the primary I2C device, usually you can just put the part number in.

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]