From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752845AbaBJMCn (ORCPT ); Mon, 10 Feb 2014 07:02:43 -0500 Received: from mail-wg0-f53.google.com ([74.125.82.53]:36572 "EHLO mail-wg0-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752418AbaBJMCj (ORCPT ); Mon, 10 Feb 2014 07:02:39 -0500 Date: Mon, 10 Feb 2014 12:02:32 +0000 From: Lee Jones To: Krzysztof Kozlowski Cc: MyungJoo Ham , Chanwoo Choi , Samuel Ortiz , Mark Brown , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Marek Szyprowski , Bartlomiej Zolnierkiewicz , Kyungmin Park Subject: Re: [PATCH v2 08/15] mfd: max77836: Add max77836 support to max14577 driver Message-ID: <20140210120232.GG22773@lee--X1> References: <1391767487-10017-1-git-send-email-k.kozlowski@samsung.com> <1391767487-10017-9-git-send-email-k.kozlowski@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1391767487-10017-9-git-send-email-k.kozlowski@samsung.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > Add Maxim 77836 support to max14577 driver. The chipsets have same MUIC > component so the extcon, charger and regulators are almost the same. The > max77836 however has also PMIC and Fuel Gauge. > > The MAX77836 uses three I2C slave addresses and has additional interrupts > (related to PMIC and Fuel Gauge). It has also Interrupt Source register, > just like MAX77686 and MAX77693. > > The MAX77836 PMIC's TOPSYS and INTSRC interrupts are reported in the > PMIC block. The PMIC block has different I2C slave address and uses own > regmap so another regmap_irq_chip is needed. > > Since we have two regmap_irq_chip, use shared interrupts on MAX77836. > > This patch adds additional defines and functions to the max14577 MFD core > driver so the driver will handle both chipsets. Also this patch replaces > "0x1 << N" with BIT(N) in defines for register masks. > > Signed-off-by: Krzysztof Kozlowski > Signed-off-by: Chanwoo Choi > Cc: Kyungmin Park > Cc: Marek Szyprowski > --- > drivers/mfd/max14577.c | 217 ++++++++++++++++++++++++++++++++-- > include/linux/mfd/max14577-private.h | 175 +++++++++++++++++++-------- > include/linux/mfd/max14577.h | 7 +- > 3 files changed, 341 insertions(+), 58 deletions(-) Much better, thanks. Acked-by: Lee Jones -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog