* [PATCH] drm/nouveau/fifo: allocate usermem as needed
@ 2014-02-10 5:57 Alexandre Courbot
2014-02-10 12:14 ` Thierry Reding
0 siblings, 1 reply; 3+ messages in thread
From: Alexandre Courbot @ 2014-02-10 5:57 UTC (permalink / raw)
To: Ben Skeggs; +Cc: nouveau, dri-devel, linux-kernel, gnurou, Alexandre Courbot
Memory was always allocated for 4096 channels. Change this to allocate
what we actually need according to the number of channels we use.
Signed-off-by: Alexandre Courbot <acourbot@nvidia.com>
---
drivers/gpu/drm/nouveau/core/engine/fifo/nve0.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/nouveau/core/engine/fifo/nve0.c b/drivers/gpu/drm/nouveau/core/engine/fifo/nve0.c
index 9a850fe19515..99c9deea248f 100644
--- a/drivers/gpu/drm/nouveau/core/engine/fifo/nve0.c
+++ b/drivers/gpu/drm/nouveau/core/engine/fifo/nve0.c
@@ -852,8 +852,8 @@ nve0_fifo_ctor(struct nouveau_object *parent, struct nouveau_object *engine,
return ret;
}
- ret = nouveau_gpuobj_new(nv_object(priv), NULL, 4096 * 0x200, 0x1000,
- NVOBJ_FLAG_ZERO_ALLOC, &priv->user.mem);
+ ret = nouveau_gpuobj_new(nv_object(priv), NULL, impl->channels * 0x200,
+ 0x1000, NVOBJ_FLAG_ZERO_ALLOC, &priv->user.mem);
if (ret)
return ret;
--
1.8.5.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] drm/nouveau/fifo: allocate usermem as needed
2014-02-10 5:57 [PATCH] drm/nouveau/fifo: allocate usermem as needed Alexandre Courbot
@ 2014-02-10 12:14 ` Thierry Reding
2014-02-14 2:02 ` [Nouveau] " Ben Skeggs
0 siblings, 1 reply; 3+ messages in thread
From: Thierry Reding @ 2014-02-10 12:14 UTC (permalink / raw)
To: Alexandre Courbot; +Cc: Ben Skeggs, nouveau, linux-kernel, dri-devel, gnurou
[-- Attachment #1: Type: text/plain, Size: 466 bytes --]
On Mon, Feb 10, 2014 at 02:57:01PM +0900, Alexandre Courbot wrote:
> Memory was always allocated for 4096 channels. Change this to allocate
> what we actually need according to the number of channels we use.
>
> Signed-off-by: Alexandre Courbot <acourbot@nvidia.com>
> ---
> drivers/gpu/drm/nouveau/core/engine/fifo/nve0.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Looks good to me:
Reviewed-by: Thierry Reding <treding@nvidia.com>
[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Nouveau] [PATCH] drm/nouveau/fifo: allocate usermem as needed
2014-02-10 12:14 ` Thierry Reding
@ 2014-02-14 2:02 ` Ben Skeggs
0 siblings, 0 replies; 3+ messages in thread
From: Ben Skeggs @ 2014-02-14 2:02 UTC (permalink / raw)
To: Thierry Reding
Cc: Alexandre Courbot, nouveau@lists.freedesktop.org, Ben Skeggs,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
On Mon, Feb 10, 2014 at 10:14 PM, Thierry Reding
<thierry.reding@gmail.com> wrote:
> On Mon, Feb 10, 2014 at 02:57:01PM +0900, Alexandre Courbot wrote:
>> Memory was always allocated for 4096 channels. Change this to allocate
>> what we actually need according to the number of channels we use.
>>
>> Signed-off-by: Alexandre Courbot <acourbot@nvidia.com>
>> ---
>> drivers/gpu/drm/nouveau/core/engine/fifo/nve0.c | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> Looks good to me:
>
> Reviewed-by: Thierry Reding <treding@nvidia.com>
Thanks guys!
>
> _______________________________________________
> Nouveau mailing list
> Nouveau@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/nouveau
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-02-14 2:02 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-02-10 5:57 [PATCH] drm/nouveau/fifo: allocate usermem as needed Alexandre Courbot
2014-02-10 12:14 ` Thierry Reding
2014-02-14 2:02 ` [Nouveau] " Ben Skeggs
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox