* [PATCH] drm/ttm: declare 'struct device' in ttm_page_alloc.h
@ 2014-02-09 9:43 Alexandre Courbot
2014-02-10 12:37 ` Thierry Reding
0 siblings, 1 reply; 3+ messages in thread
From: Alexandre Courbot @ 2014-02-09 9:43 UTC (permalink / raw)
To: David Airlie; +Cc: dri-devel, linux-kernel, gnurou, Alexandre Courbot
Declare 'struct device' explicitly in ttm_page_alloc.h as this file
does not include any file declaring it. This removes the following
warning:
warning: 'struct device' declared inside parameter list
Signed-off-by: Alexandre Courbot <acourbot@nvidia.com>
---
This warning was visible when compiling Nouveau on -next today.
include/drm/ttm/ttm_page_alloc.h | 2 ++
1 file changed, 2 insertions(+)
diff --git a/include/drm/ttm/ttm_page_alloc.h b/include/drm/ttm/ttm_page_alloc.h
index d1f61bf..49a8284 100644
--- a/include/drm/ttm/ttm_page_alloc.h
+++ b/include/drm/ttm/ttm_page_alloc.h
@@ -29,6 +29,8 @@
#include <drm/ttm/ttm_bo_driver.h>
#include <drm/ttm/ttm_memory.h>
+struct device;
+
/**
* Initialize pool allocator.
*/
--
1.8.5.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] drm/ttm: declare 'struct device' in ttm_page_alloc.h
2014-02-09 9:43 [PATCH] drm/ttm: declare 'struct device' in ttm_page_alloc.h Alexandre Courbot
@ 2014-02-10 12:37 ` Thierry Reding
2014-02-20 4:12 ` Alexandre Courbot
0 siblings, 1 reply; 3+ messages in thread
From: Thierry Reding @ 2014-02-10 12:37 UTC (permalink / raw)
To: Alexandre Courbot; +Cc: David Airlie, gnurou, linux-kernel, dri-devel
[-- Attachment #1: Type: text/plain, Size: 680 bytes --]
On Sun, Feb 09, 2014 at 06:43:18PM +0900, Alexandre Courbot wrote:
> Declare 'struct device' explicitly in ttm_page_alloc.h as this file
> does not include any file declaring it. This removes the following
> warning:
>
> warning: 'struct device' declared inside parameter list
>
> Signed-off-by: Alexandre Courbot <acourbot@nvidia.com>
> ---
> This warning was visible when compiling Nouveau on -next today.
>
> include/drm/ttm/ttm_page_alloc.h | 2 ++
> 1 file changed, 2 insertions(+)
I don't think I've seen this on x86, but I've certainly encountered the
same warning when building nouveau on ARM, so:
Reviewed-by: Thierry Reding <treding@nvidia.com>
[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] drm/ttm: declare 'struct device' in ttm_page_alloc.h
2014-02-10 12:37 ` Thierry Reding
@ 2014-02-20 4:12 ` Alexandre Courbot
0 siblings, 0 replies; 3+ messages in thread
From: Alexandre Courbot @ 2014-02-20 4:12 UTC (permalink / raw)
To: David Airlie
Cc: Thierry Reding, Alexandre Courbot, Linux Kernel Mailing List,
dri-devel@lists.freedesktop.org
Ping, David?
On Mon, Feb 10, 2014 at 9:37 PM, Thierry Reding
<thierry.reding@gmail.com> wrote:
> On Sun, Feb 09, 2014 at 06:43:18PM +0900, Alexandre Courbot wrote:
>> Declare 'struct device' explicitly in ttm_page_alloc.h as this file
>> does not include any file declaring it. This removes the following
>> warning:
>>
>> warning: 'struct device' declared inside parameter list
>>
>> Signed-off-by: Alexandre Courbot <acourbot@nvidia.com>
>> ---
>> This warning was visible when compiling Nouveau on -next today.
>>
>> include/drm/ttm/ttm_page_alloc.h | 2 ++
>> 1 file changed, 2 insertions(+)
>
> I don't think I've seen this on x86, but I've certainly encountered the
> same warning when building nouveau on ARM, so:
>
> Reviewed-by: Thierry Reding <treding@nvidia.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-02-20 4:12 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-02-09 9:43 [PATCH] drm/ttm: declare 'struct device' in ttm_page_alloc.h Alexandre Courbot
2014-02-10 12:37 ` Thierry Reding
2014-02-20 4:12 ` Alexandre Courbot
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox