Re: [PATCH v3] mfd: MAX6650/6651 support

[Lee Jones <lee.jones@linaro.org>]

> >> +static struct mfd_cell max665x_devs[] = {
> >> +     { .name = "max6651-gpio", },
> >> +     { .name = "max6650", }, /* hwmon driver */
> >
> > What happened to renaming the hwmon driver, so we can have
> > "max6650-hwmon" here?
> 
> I will add the alias in the next patch (e.g. hwmon change). I can come
> back to this and rename then.

Better add this patch _after_ that change. That will prevent any
inherently awkward to handing 'cross subsystem' patches.

> >> +static const struct i2c_device_id max665x_id[] = {
> >> +     { "max6650", TYPE_MAX6650 },
> >> +     { "max6651", TYPE_MAX6651 },
> >> +     {},
> >
> > Can you remind me where these IDs are being used?
> 
> Strictly speaking, not in this change, so I can remove it and add
> later if needed.

Please remove them if they're not being used.

> >> +};
> >> +MODULE_DEVICE_TABLE(i2c, max665x_id);
> >> +
> >> +static struct i2c_driver max665x_driver = {
> >> +     .driver = {
> >> +             .name = "max665x",
> >> +             .owner = THIS_MODULE,
> >
> > All new drivers are required to support Device Tree.
> 
> Do you have some recommendation for documentation, examples, etc? I am
> new to this.

Documentation/devicetree/usage-model.txt
Documentation/devicetree/bindings/mfd/*

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog