Re: [PATCH 0/3] Fix perf build breakages in 3.13

Arnaldo Carvalho de Melo
2014-02-06T14:40:12Z

Em Thu, Feb 06, 2014 at 02:13:15PM +0000, Ben Hutchings escreveu:
> On Thu, 2014-02-06 at 10:48 -0300, Arnaldo Carvalho de Melo wrote:
> > Em Thu, Feb 06, 2014 at 12:59:21AM +0000, Ben Hutchings escreveu:
> > > perf no longer compiles on powerpc and sparc due to changes in the trace
> > > sub-command. This series fixes those compile errors; I compile-tested
> > > in Debian sid on armhf, i386, powerpc and sparc.
> > >
> > > I would much prefer not to revert the tty ioctl decoding but I think
> > > it's going to take a much more sophisticated approach to do it right
> > > across all supported architectures.
> >
> > Second thought on the revert one:
> >
> > Do you have a problem of switching the big hammer to one that makes this
> > work just on x86/x86-64?
>
> That seems reasonable as a temporary measure.

Thank you, I'll do that then and hope to work on the right fix in the
near future, if nobody does it first.

- Arnaldo

> Ben.
>
> > That way at least those on these arches can have this while the correct
> > solution is worked out.
> >
> > - Arnaldo
> >
> > > Ben.
> > >
> > > Ben Hutchings (3):
> > > Revert "perf trace: Initial beautifier for ioctl's 'cmd' arg"
> > > perf trace: Add fallback definition of EFD_SEMAPHORE
> > > perf trace: Decode architecture-specific signal numbers
> > >
> > > tools/perf/builtin-trace.c | 48 ++++++++++++++--------------------------------
> > > 1 file changed, 14 insertions(+), 34 deletions(-)
> > >
> > >
> > > --
> > > Ben Hutchings
> > > It is a miracle that curiosity survives formal education. - Albert Einstein
> >
> >
>
> --
> Ben Hutchings
> It is a miracle that curiosity survives formal education. - Albert Einstein