Re: [PATCH 0/3] Fix perf build breakages in 3.13

Ben Hutchings
2014-02-10T21:32:26Z

[-- Attachment #1: Type: text/plain, Size: 2564 bytes --]

On Mon, 2014-02-10 at 14:52 -0300, Arnaldo Carvalho de Melo wrote:
> Em Thu, Feb 06, 2014 at 02:13:15PM +0000, Ben Hutchings escreveu:
> > On Thu, 2014-02-06 at 10:48 -0300, Arnaldo Carvalho de Melo wrote:
> > > Em Thu, Feb 06, 2014 at 12:59:21AM +0000, Ben Hutchings escreveu:
> > > > perf no longer compiles on powerpc and sparc due to changes in the trace
> > > > sub-command. This series fixes those compile errors; I compile-tested
> > > > in Debian sid on armhf, i386, powerpc and sparc.
> > > >
> > > > I would much prefer not to revert the tty ioctl decoding but I think
> > > > it's going to take a much more sophisticated approach to do it right
> > > > across all supported architectures.
> > >
> > > Second thought on the revert one:
> > >
> > > Do you have a problem of switching the big hammer to one that makes this
> > > work just on x86/x86-64?
> >
> > That seems reasonable as a temporary measure.
>
> Applying this to my perf/urgent branch, ack?
>
> - Arnaldo
>
> commit 57f7077f41104c5499a89803f58b5886ee51555f
> Author: Arnaldo Carvalho de Melo <acme@redhat.com>
> Date: Mon Feb 10 14:09:48 2014 -0300
>
> perf trace: Fix ioctl 'request' beautifier build problems on !(i386 || x86_64) arches
>
> Supporting decoding the ioctl 'request' parameter needs more work to
> properly support more architectures, the current approach doesn't work
> on at least powerpc and sparc, as reported by Ben Hutchings in
> http://lkml.kernel.org/r/1391593985.3003.48.camel@deadeye.wl.decadent.org.uk .
>
> Work around that by making it to be ifdefed for the architectures known
> to work with the current, limited approach, i386 and x86_64 till better
> code is written.
>
> Reported-by: Ben Hutchings <ben@decadent.org.uk>
> Cc: Adrian Hunter <adrian.hunter@intel.com>
> Cc: David Ahern <dsahern@gmail.com>
> Cc: Frederic Weisbecker <fweisbec@gmail.com>
> Cc: Jiri Olsa <jolsa@redhat.com>
> Cc: Mike Galbraith <efault@gmx.de>
> Cc: Namhyung Kim <namhyung@kernel.org>
> Cc: Paul Mackerras <paulus@samba.org>
> Cc: Peter Zijlstra <peterz@infradead.org>
> Cc: Stephane Eranian <eranian@google.com>
[...]

Please add:

Cc: <stable@vger.kernel.org> # 3.13
Fixes: 78645cf3ed32 ("perf trace: Initial beautifier for ioctl's 'cmd' arg")

Ben.

--
Ben Hutchings
We get into the habit of living before acquiring the habit of thinking.
- Albert Camus