From: Nicolin Chen <Guangyu.Chen@freescale.com>
To: Xiubo Li-B47053 <Li.Xiubo@freescale.com>
Cc: "shawn.guo@linaro.org" <shawn.guo@linaro.org>,
"broonie@kernel.org" <broonie@kernel.org>,
"lgirdwood@gmail.com" <lgirdwood@gmail.com>,
"perex@perex.cz" <perex@perex.cz>,
"tiwai@suse.de" <tiwai@suse.de>,
"alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/2] ASoC: fsl-spdif: big-endian support
Date: Tue, 11 Feb 2014 16:06:13 +0800 [thread overview]
Message-ID: <20140211080612.GC18803@MrMyself> (raw)
In-Reply-To: <1a10273e564a4bb7a5aafe3f01ccffa2@BY2PR03MB505.namprd03.prod.outlook.com>
On Tue, Feb 11, 2014 at 03:39:44PM +0800, Xiubo Li-B47053 wrote:
>
>
> > > + - big-endian : If this property is absent, the native endian mode will
> > > + be in use as default, or the big endian mode will be in use for all the
> > > + device registers.
> > > +
> >
> > @Shawn
> > Does DT have an existing approach to determine if the current SoC this IP
> > uses is BE or LE? I am thinking the scenario that if all drivers support
> > BE/LE while the SoC is big-endian, all the nodes in the DT would have to
> > include a duplicated property (big-endian).
> >
>
> @Nicolin, @Shawn
> One special scenario likes the LS1 platform, the CPU and a few devices are in
> LE mode and other devices will be in BE mode.
Hmm... a bit strange to me. But I think it then should be fine here if it's
plausible as you describe.
Please revise the patch and send it to see if there's any comment from others.
And for both revised patches:
Acked-by: Nicolin Chen <Guangyu.Chen@freescale.com>
Thank you
prev parent reply other threads:[~2014-02-11 8:16 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-11 5:41 [PATCH 1/2] ASoC: fsl-spdif: big-endian support Xiubo Li
2014-02-11 5:41 ` [PATCH 2/2] ASoC: fsl-esai: " Xiubo Li
2014-02-11 7:14 ` Nicolin Chen
2014-02-11 7:27 ` Li.Xiubo
2014-02-11 7:10 ` [PATCH 1/2] ASoC: fsl-spdif: " Nicolin Chen
2014-02-11 7:25 ` Li.Xiubo
2014-02-11 7:39 ` Li.Xiubo
2014-02-11 8:06 ` Nicolin Chen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140211080612.GC18803@MrMyself \
--to=guangyu.chen@freescale.com \
--cc=Li.Xiubo@freescale.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=shawn.guo@linaro.org \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox