From: Lee Jones <lee.jones@linaro.org>
To: Colin King <colin.king@canonical.com>
Cc: Samuel Ortiz <sameo@linux.intel.com>,
linux-kernel@vger.kernel.org, rogerq@ti.com
Subject: Re: [PATCH][v2] mfd: omap-usb-tll: fix cppcheck sizeof warning
Date: Tue, 11 Feb 2014 10:03:53 +0000 [thread overview]
Message-ID: <20140211100353.GL32042@lee--X1> (raw)
In-Reply-To: <1392111533-23053-1-git-send-email-colin.king@canonical.com>
> From: Colin Ian King <colin.king@canonical.com>
>
> Static analysis from cppcheck issued the following warning:
>
> [drivers/mfd/omap-usb-tll.c:255]: (warning) Found calculation
> inside sizeof().
>
> The current size calculation is not obvious and is easy to
> miscomprehend, so re-work the size of the allocation based
> on the size of the struct pointer and quantity to allocate.
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> drivers/mfd/omap-usb-tll.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Applied to my -fixes branch with Roger's Ack.
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
prev parent reply other threads:[~2014-02-11 10:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-11 9:38 [PATCH][v2] mfd: omap-usb-tll: fix cppcheck sizeof warning Colin King
2014-02-11 9:40 ` Roger Quadros
2014-02-11 10:03 ` Lee Jones [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140211100353.GL32042@lee--X1 \
--to=lee.jones@linaro.org \
--cc=colin.king@canonical.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rogerq@ti.com \
--cc=sameo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox