* [PATCH][v2] mfd: omap-usb-tll: fix cppcheck sizeof warning
@ 2014-02-11 9:38 Colin King
2014-02-11 9:40 ` Roger Quadros
2014-02-11 10:03 ` Lee Jones
0 siblings, 2 replies; 3+ messages in thread
From: Colin King @ 2014-02-11 9:38 UTC (permalink / raw)
To: Samuel Ortiz, Lee Jones, linux-kernel; +Cc: rogerq
From: Colin Ian King <colin.king@canonical.com>
Static analysis from cppcheck issued the following warning:
[drivers/mfd/omap-usb-tll.c:255]: (warning) Found calculation
inside sizeof().
The current size calculation is not obvious and is easy to
miscomprehend, so re-work the size of the allocation based
on the size of the struct pointer and quantity to allocate.
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/mfd/omap-usb-tll.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mfd/omap-usb-tll.c b/drivers/mfd/omap-usb-tll.c
index 5ee50f7..532eacab 100644
--- a/drivers/mfd/omap-usb-tll.c
+++ b/drivers/mfd/omap-usb-tll.c
@@ -252,7 +252,7 @@ static int usbtll_omap_probe(struct platform_device *pdev)
break;
}
- tll->ch_clk = devm_kzalloc(dev, sizeof(struct clk * [tll->nch]),
+ tll->ch_clk = devm_kzalloc(dev, sizeof(struct clk *) * tll->nch,
GFP_KERNEL);
if (!tll->ch_clk) {
ret = -ENOMEM;
--
1.9.rc1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH][v2] mfd: omap-usb-tll: fix cppcheck sizeof warning
2014-02-11 9:38 [PATCH][v2] mfd: omap-usb-tll: fix cppcheck sizeof warning Colin King
@ 2014-02-11 9:40 ` Roger Quadros
2014-02-11 10:03 ` Lee Jones
1 sibling, 0 replies; 3+ messages in thread
From: Roger Quadros @ 2014-02-11 9:40 UTC (permalink / raw)
To: Colin King, Samuel Ortiz, Lee Jones, linux-kernel
On 02/11/2014 11:38 AM, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Static analysis from cppcheck issued the following warning:
>
> [drivers/mfd/omap-usb-tll.c:255]: (warning) Found calculation
> inside sizeof().
>
> The current size calculation is not obvious and is easy to
> miscomprehend, so re-work the size of the allocation based
> on the size of the struct pointer and quantity to allocate.
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> drivers/mfd/omap-usb-tll.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mfd/omap-usb-tll.c b/drivers/mfd/omap-usb-tll.c
> index 5ee50f7..532eacab 100644
> --- a/drivers/mfd/omap-usb-tll.c
> +++ b/drivers/mfd/omap-usb-tll.c
> @@ -252,7 +252,7 @@ static int usbtll_omap_probe(struct platform_device *pdev)
> break;
> }
>
> - tll->ch_clk = devm_kzalloc(dev, sizeof(struct clk * [tll->nch]),
> + tll->ch_clk = devm_kzalloc(dev, sizeof(struct clk *) * tll->nch,
> GFP_KERNEL);
> if (!tll->ch_clk) {
> ret = -ENOMEM;
>
Thanks for the patch Colin.
Acked-by: Roger Quadros <rogerq@ti.com>
--
cheers,
-roger
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH][v2] mfd: omap-usb-tll: fix cppcheck sizeof warning
2014-02-11 9:38 [PATCH][v2] mfd: omap-usb-tll: fix cppcheck sizeof warning Colin King
2014-02-11 9:40 ` Roger Quadros
@ 2014-02-11 10:03 ` Lee Jones
1 sibling, 0 replies; 3+ messages in thread
From: Lee Jones @ 2014-02-11 10:03 UTC (permalink / raw)
To: Colin King; +Cc: Samuel Ortiz, linux-kernel, rogerq
> From: Colin Ian King <colin.king@canonical.com>
>
> Static analysis from cppcheck issued the following warning:
>
> [drivers/mfd/omap-usb-tll.c:255]: (warning) Found calculation
> inside sizeof().
>
> The current size calculation is not obvious and is easy to
> miscomprehend, so re-work the size of the allocation based
> on the size of the struct pointer and quantity to allocate.
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> drivers/mfd/omap-usb-tll.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Applied to my -fixes branch with Roger's Ack.
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-02-11 10:04 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-02-11 9:38 [PATCH][v2] mfd: omap-usb-tll: fix cppcheck sizeof warning Colin King
2014-02-11 9:40 ` Roger Quadros
2014-02-11 10:03 ` Lee Jones
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox