From: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
To: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Paul Gortmaker <paul.gortmaker@windriver.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] nohz: ensure users are aware boot CPU is not NO_HZ_FULL
Date: Tue, 11 Feb 2014 07:24:16 -0800 [thread overview]
Message-ID: <20140211152416.GT4250@linux.vnet.ibm.com> (raw)
In-Reply-To: <20140210161933.GB21060@localhost.localdomain>
On Mon, Feb 10, 2014 at 05:19:34PM +0100, Frederic Weisbecker wrote:
> On Thu, Feb 06, 2014 at 01:36:21PM -0500, Paul Gortmaker wrote:
> > This bit of information is in the Kconfig help text:
> >
> > Note the boot CPU will still be kept outside the range to
> > handle the timekeeping duty.
> >
> > However neither the variable NO_HZ_FULL_ALL, or the prompt
> > convey this important detail, so lets add it to the prompt
> > to make it more explicitly obvious to the average user.
> >
> > Cc: Frederic Weisbecker <fweisbec@gmail.com>
> > Cc: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
>
> Paul, I guess I can keep your ack on this 2nd version?
Please do!
Thanx, Paul
> > Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
>
> Applied, thanks a lot!
>
> > ---
> >
> > v2: use "CPU 0" instead of "boot CPU".
> >
> > kernel/time/Kconfig | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/kernel/time/Kconfig b/kernel/time/Kconfig
> > index 3ce6e8c5f3fc..f448513a45ed 100644
> > --- a/kernel/time/Kconfig
> > +++ b/kernel/time/Kconfig
> > @@ -124,7 +124,7 @@ config NO_HZ_FULL
> > endchoice
> >
> > config NO_HZ_FULL_ALL
> > - bool "Full dynticks system on all CPUs by default"
> > + bool "Full dynticks system on all CPUs by default (except CPU 0)"
> > depends on NO_HZ_FULL
> > help
> > If the user doesn't pass the nohz_full boot option to
> > --
> > 1.8.5.2
> >
> > --
> > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> > the body of a message to majordomo@vger.kernel.org
> > More majordomo info at http://vger.kernel.org/majordomo-info.html
> > Please read the FAQ at http://www.tux.org/lkml/
>
next prev parent reply other threads:[~2014-02-11 15:24 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-28 17:10 [PATCH] nohz: ensure users are aware boot CPU is not NO_HZ_FULL Paul Gortmaker
2014-01-29 0:06 ` Paul E. McKenney
2014-01-31 16:38 ` Frederic Weisbecker
2014-02-06 18:33 ` Paul Gortmaker
2014-02-06 18:36 ` [PATCH v2] " Paul Gortmaker
2014-02-10 16:19 ` Frederic Weisbecker
2014-02-11 15:24 ` Paul E. McKenney [this message]
2014-02-26 20:07 ` [tip:timers/core] " tip-bot for Paul Gortmaker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140211152416.GT4250@linux.vnet.ibm.com \
--to=paulmck@linux.vnet.ibm.com \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=paul.gortmaker@windriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox