From: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
To: Josh Triplett <josh@freedesktop.org>
Cc: Dongsheng Yang <yangds.fnst@cn.fujitsu.com>,
linux-kernel@vger.kernel.org,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@kernel.org>
Subject: Re: [PATCH 5/9] rcu: Use MAX_NICE to replace hard coding of 19.
Date: Tue, 11 Feb 2014 08:13:13 -0800 [thread overview]
Message-ID: <20140211161313.GV4250@linux.vnet.ibm.com> (raw)
In-Reply-To: <20140211153732.GA2985@leaf>
On Tue, Feb 11, 2014 at 07:37:32AM -0800, Josh Triplett wrote:
> On Tue, Feb 11, 2014 at 03:34:49PM +0800, Dongsheng Yang wrote:
> > Signed-off-by: Dongsheng Yang <yangds.fnst@cn.fujitsu.com>
> > cc: Josh Triplett <josh@freedesktop.org>
> > cc: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
> > cc: Peter Zijlstra <peterz@infradead.org>
> > cc: Ingo Molnar <mingo@kernel.org>
>
> Reviewed-by: Josh Triplett <josh@joshtriplett.org>
I get complaints about MAX_NICE being undefined, and I don't see any
definition of MAX_NICE in sched.h as of 3.14-rc2. Am I looking in
the wrong place, or is this symbol not yet quite in mainline?
Thanx, Paul
> > kernel/rcu/torture.c | 8 ++++----
> > 1 file changed, 4 insertions(+), 4 deletions(-)
> >
> > diff --git a/kernel/rcu/torture.c b/kernel/rcu/torture.c
> > index 732f8ae..219761d 100644
> > --- a/kernel/rcu/torture.c
> > +++ b/kernel/rcu/torture.c
> > @@ -805,7 +805,7 @@ rcu_torture_writer(void *arg)
> > static DEFINE_RCU_RANDOM(rand);
> >
> > VERBOSE_PRINTK_STRING("rcu_torture_writer task started");
> > - set_user_nice(current, 19);
> > + set_user_nice(current, MAX_NICE);
> >
> > do {
> > schedule_timeout_uninterruptible(1);
> > @@ -871,7 +871,7 @@ rcu_torture_fakewriter(void *arg)
> > DEFINE_RCU_RANDOM(rand);
> >
> > VERBOSE_PRINTK_STRING("rcu_torture_fakewriter task started");
> > - set_user_nice(current, 19);
> > + set_user_nice(current, MAX_NICE);
> >
> > do {
> > schedule_timeout_uninterruptible(1 + rcu_random(&rand)%10);
> > @@ -987,7 +987,7 @@ rcu_torture_reader(void *arg)
> > unsigned long long ts;
> >
> > VERBOSE_PRINTK_STRING("rcu_torture_reader task started");
> > - set_user_nice(current, 19);
> > + set_user_nice(current, MAX_NICE);
> > if (irqreader && cur_ops->irq_capable)
> > setup_timer_on_stack(&t, rcu_torture_timer, 0);
> >
> > @@ -1584,7 +1584,7 @@ static int rcu_torture_barrier_cbs(void *arg)
> >
> > init_rcu_head_on_stack(&rcu);
> > VERBOSE_PRINTK_STRING("rcu_torture_barrier_cbs task started");
> > - set_user_nice(current, 19);
> > + set_user_nice(current, MAX_NICE);
> > do {
> > wait_event(barrier_cbs_wq[myid],
> > (newphase =
> > --
> > 1.8.2.1
> >
>
next prev parent reply other threads:[~2014-02-11 16:31 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-11 7:34 [PATCH 0/9] Add MAX_NICE, MIN_NICE and NICE_WIDTH macros in prio.h Dongsheng Yang
2014-02-11 7:34 ` [PATCH 1/9] sched: Prio: Use DEFAULT_PRIO to define NICE_TO_PRIO and PRIO_TO_NICE Dongsheng Yang
2014-02-21 21:32 ` [tip:sched/core] " tip-bot for Dongsheng Yang
2014-02-22 18:03 ` [tip:sched/core] sched/prio: Use DEFAULT_PRIO to define NICE_TO_PRIO() and PRIO_TO_NICE() tip-bot for Dongsheng Yang
2014-02-11 7:34 ` [PATCH 2/9] sched: prio: Add 3 macros of MAX_NICE, MIN_NICE and NICE_WIDTH in prio.h Dongsheng Yang
2014-02-21 21:33 ` [tip:sched/core] " tip-bot for Dongsheng Yang
2014-02-22 18:03 ` [tip:sched/core] sched/prio: " tip-bot for Dongsheng Yang
2014-02-11 7:34 ` [PATCH 3/9] sched: prio: Use NICE_WIDTH macro to avoid using of hard coding of 40 and 20 " Dongsheng Yang
2014-02-21 21:33 ` [tip:sched/core] " tip-bot for Dongsheng Yang
2014-02-11 7:34 ` [PATCH 4/9] sched: prio: Add spaces before and after operator of '-' Dongsheng Yang
2014-02-21 21:33 ` [tip:sched/core] " tip-bot for Dongsheng Yang
2014-02-11 7:34 ` [PATCH 5/9] rcu: Use MAX_NICE to replace hard coding of 19 Dongsheng Yang
2014-02-11 15:37 ` Josh Triplett
2014-02-11 16:13 ` Paul E. McKenney [this message]
2014-02-11 16:42 ` Peter Zijlstra
2014-02-11 17:42 ` Paul E. McKenney
2014-02-21 21:33 ` [tip:sched/core] " tip-bot for Dongsheng Yang
2014-02-22 18:03 ` [tip:sched/core] rcu: Use MAX_NICE to replace hardcoding " tip-bot for Dongsheng Yang
2014-02-11 7:34 ` [PATCH 6/9] sched: Replace hardcoding of -20 and 19 with MIN_NICE and MAX_NICE Dongsheng Yang
2014-02-21 21:33 ` [tip:sched/core] " tip-bot for Dongsheng Yang
2014-02-22 18:03 ` tip-bot for Dongsheng Yang
2014-02-11 7:34 ` [PATCH 7/9] sys: " Dongsheng Yang
2014-02-11 18:27 ` Kees Cook
2014-02-12 3:59 ` Dongsheng Yang
2014-02-12 6:40 ` Kees Cook
2014-02-21 21:34 ` [tip:sched/core] " tip-bot for Dongsheng Yang
2014-02-22 18:04 ` tip-bot for Dongsheng Yang
2014-02-11 7:34 ` [PATCH 8/9] workqueue: " Dongsheng Yang
2014-02-11 17:50 ` Tejun Heo
2014-02-21 21:34 ` [tip:sched/core] " tip-bot for Dongsheng Yang
2014-02-22 18:04 ` tip-bot for Dongsheng Yang
2014-02-11 7:34 ` [PATCH 9/9] trace: Replace hardcoding of 19 with MAX_NICE Dongsheng Yang
2014-02-22 9:05 ` Dongsheng Yang
2014-02-22 9:27 ` Peter Zijlstra
2014-02-24 10:46 ` Peter Zijlstra
2014-02-24 14:08 ` Dongsheng Yang
2014-02-24 14:12 ` [PATCH Resend] " Dongsheng Yang
2014-02-24 14:22 ` Peter Zijlstra
2014-02-24 14:29 ` Steven Rostedt
2014-02-24 14:48 ` Peter Zijlstra
2014-02-27 13:33 ` [tip:sched/core] " tip-bot for Dongsheng Yang
2014-02-14 9:22 ` [PATCH 0/9] Add MAX_NICE, MIN_NICE and NICE_WIDTH macros in prio.h Dongsheng Yang
2014-02-14 9:51 ` Peter Zijlstra
2014-02-14 9:54 ` Dongsheng Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140211161313.GV4250@linux.vnet.ibm.com \
--to=paulmck@linux.vnet.ibm.com \
--cc=josh@freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=yangds.fnst@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox