From: Stanislaw Gruszka <sgruszka@redhat.com>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: poma <pomidorabelisima@gmail.com>,
Linux Kernel list <linux-kernel@vger.kernel.org>,
linux-pm@vger.kernel.org, Olaf Hering <olaf@aepfle.de>,
Dave Jones <davej@redhat.com>,
"Justin M. Forbes" <jforbes@redhat.com>,
Josh Boyer <jwboyer@redhat.com>,
Mailing-List fedora-kernel <kernel@lists.fedoraproject.org>
Subject: Re: WARNING: CPU: 1 PID: 0 at kernel/time/tick-broadcast.c:668 tick_broadcast_oneshot_control+0x17d/0x190()
Date: Tue, 11 Feb 2014 17:27:21 +0100 [thread overview]
Message-ID: <20140211162720.GA3729@redhat.com> (raw)
In-Reply-To: <alpine.DEB.2.02.1402111702090.21991@ionos.tec.linutronix.de>
> > I came with a below patch, which also clear pending mask, but perhaps
>
> Fun. I came up with the exact same solution independent of you and I
> tested it on real C1E contaminated hardware.
>
> > oneshot_mask should not be cleared on tick_broadcast_setup_oneshot(),
> > or should be cleared only conditionally, or some other solution is
>
> We can do it unconditionally. It creates consistent state in all
> corner cases.
>
> There are other solutions to the problem, but that needs a major
> rework of the broadcast code. I so wish that this mess would have
> never been necessary at all ...
Thomas, please post/apply patch, which you think is the most
appropriate.
Thanks
Stanislaw
next prev parent reply other threads:[~2014-02-11 16:28 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-10 3:42 WARNING: CPU: 1 PID: 0 at kernel/time/tick-broadcast.c:668 tick_broadcast_oneshot_control+0x17d/0x190() poma
2014-02-10 10:06 ` Thomas Gleixner
2014-02-10 18:59 ` poma
2014-02-11 8:23 ` Stanislaw Gruszka
2014-02-11 16:07 ` Thomas Gleixner
2014-02-11 16:27 ` Stanislaw Gruszka [this message]
2014-02-11 14:25 ` Thomas Gleixner
2014-02-11 20:44 ` poma
2014-02-13 20:57 ` [tip:timers/urgent] tick: Clear broadcast pending bit when switching to oneshot tip-bot for Thomas Gleixner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140211162720.GA3729@redhat.com \
--to=sgruszka@redhat.com \
--cc=davej@redhat.com \
--cc=jforbes@redhat.com \
--cc=jwboyer@redhat.com \
--cc=kernel@lists.fedoraproject.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=olaf@aepfle.de \
--cc=pomidorabelisima@gmail.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox