From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752746AbaBKQ2Z (ORCPT ); Tue, 11 Feb 2014 11:28:25 -0500 Received: from mx1.redhat.com ([209.132.183.28]:65040 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751585AbaBKQ2V (ORCPT ); Tue, 11 Feb 2014 11:28:21 -0500 Date: Tue, 11 Feb 2014 17:27:21 +0100 From: Stanislaw Gruszka To: Thomas Gleixner Cc: poma , Linux Kernel list , linux-pm@vger.kernel.org, Olaf Hering , Dave Jones , "Justin M. Forbes" , Josh Boyer , Mailing-List fedora-kernel Subject: Re: WARNING: CPU: 1 PID: 0 at kernel/time/tick-broadcast.c:668 tick_broadcast_oneshot_control+0x17d/0x190() Message-ID: <20140211162720.GA3729@redhat.com> References: <52F84A9B.5020008@gmail.com> <52F9219B.5020003@gmail.com> <20140211082306.GA1528@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > > I came with a below patch, which also clear pending mask, but perhaps > > Fun. I came up with the exact same solution independent of you and I > tested it on real C1E contaminated hardware. > > > oneshot_mask should not be cleared on tick_broadcast_setup_oneshot(), > > or should be cleared only conditionally, or some other solution is > > We can do it unconditionally. It creates consistent state in all > corner cases. > > There are other solutions to the problem, but that needs a major > rework of the broadcast code. I so wish that this mess would have > never been necessary at all ... Thomas, please post/apply patch, which you think is the most appropriate. Thanks Stanislaw