From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: Jason Cooper <jason@lakedaemon.net>
Cc: Josh Cartwright <joshc@codeaurora.org>,
Andrew Lunn <andrew@lunn.ch>,
Russell King <linux@arm.linux.org.uk>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
Gregory Clement <gregory.clement@free-electrons.com>,
linux-arm-kernel@lists.infradead.org,
Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>
Subject: Re: [PATCH 4/8] ARM: mvebu: make use of of_find_matching_node_and_match
Date: Tue, 11 Feb 2014 18:10:48 +0100 [thread overview]
Message-ID: <20140211181048.6934bdd3@skate> (raw)
In-Reply-To: <20140211165314.GA8533@titan.lakedaemon.net>
Dear Jason Cooper,
On Tue, 11 Feb 2014 11:53:14 -0500, Jason Cooper wrote:
> > - np = of_find_matching_node(NULL, of_system_controller_table);
> > + np = of_find_matching_node_and_match(NULL, of_system_controller_table,
> > + &match);
> > if (np) {
> > - const struct of_device_id *match =
> > - of_match_node(of_system_controller_table, np);
>
>
> > - BUG_ON(!match);
>
> Gregory, is it ok to remove this? It was added with the original code
> submission for mach-mvebu. mvebu_restart() will handle this
> gracefully...
The BUG_ON here can normally never be reached. If
of_find_matching_node() returns a non-NULL result, then of_match_node()
should also return a non-NULL result.
Or I'm missing something :)
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2014-02-11 17:10 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-11 16:23 [PATCH 0/8] of_find_matching_node/of_match_node -> of_find_matching_node_and_match Josh Cartwright
2014-02-11 16:23 ` [PATCH 1/8] bus: arm-cci: make use of of_find_matching_node_and_match Josh Cartwright
2014-02-11 16:24 ` [PATCH 2/8] bus: mvebu-mbus: " Josh Cartwright
2014-02-11 16:39 ` Jason Cooper
2014-02-11 19:22 ` Jason Cooper
2014-02-11 16:24 ` [PATCH 3/8] ARM: at91: " Josh Cartwright
2014-02-11 17:46 ` Nicolas Ferre
2014-02-11 18:44 ` Josh Cartwright
2014-02-11 16:24 ` [PATCH 4/8] ARM: mvebu: " Josh Cartwright
2014-02-11 16:41 ` Thomas Petazzoni
2014-02-11 16:53 ` Jason Cooper
2014-02-11 17:10 ` Thomas Petazzoni [this message]
2014-02-11 17:31 ` Gregory CLEMENT
2014-02-11 17:34 ` Jason Cooper
2014-02-11 17:43 ` Josh Cartwright
2014-02-11 19:29 ` Jason Cooper
2014-02-11 16:24 ` [PATCH 5/8] ARM: prima2: " Josh Cartwright
2014-02-11 16:24 ` [PATCH 6/8] ARM: l2x0: " Josh Cartwright
2014-02-11 16:24 ` [PATCH 7/8] C6X: " Josh Cartwright
2014-02-11 16:24 ` [PATCH 8/8] cpufreq: ppc: " Josh Cartwright
2014-02-12 5:01 ` Viresh Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140211181048.6934bdd3@skate \
--to=thomas.petazzoni@free-electrons.com \
--cc=andrew@lunn.ch \
--cc=devicetree@vger.kernel.org \
--cc=gregory.clement@free-electrons.com \
--cc=jason@lakedaemon.net \
--cc=joshc@codeaurora.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=sebastian.hesselbarth@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox